-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VO-1120] refactor(FolderPicker): Use ListItem instead File #3236
[VO-1120] refactor(FolderPicker): Use ListItem instead File #3236
Conversation
BundleMonFiles updated (6)
Unchanged files (12)
Total files change +5.54KB +0.11% Groups updated (4)
Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
{Array.from({ length: 8 }, (_, index) => ( | ||
<ListItemSkeleton | ||
key={`key_file_placeholder_${index}`} | ||
gutters={gutters} | ||
hasSecondary | ||
divider={index !== 7} | ||
/> | ||
))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Ca pourrait sans doute être mémo sur isMobile pour éviter les multiples créations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je dirais qu'il y a pas besoin car le temps de calcul de gutters
n'est pas assez élever pour que ça soit pertinent et le composant n'est pas re-rendu car les paramètres ne change pas durant le rendu
@@ -95,4 +100,9 @@ FileThumbnail.propTypes = { | |||
size: PropTypes.number | |||
} | |||
|
|||
FileThumbnail.defaultProps = { | |||
showSharedBadge: false, | |||
componentsProps: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
componentsProps: {} | |
componentsProps: { | |
sharedBadge: {} | |
} |
Ce qui permettrai d'éviter la condition componentsProps.sharedBadge ?? {}
plus haut ?
dec0a7c
to
5124ca0
Compare
This decouples the display of the file table from that of the FolderPicker modal. This will allow you to change the lines as Link in the table in order to take advantage of the default mechanisms of browsers
5124ca0
to
be18bd0
Compare
This decouples the display of the file table from that of the FolderPicker modal. This will allow you to change the lines as Link in the table in order to take advantage of the default mechanisms of browsers
Related PRs :