Add Viewer bottomSheet for mobile #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
6 times, most recently
from
479c803 to
14705b4
Compare
Crash--
reviewed
Mar 15, 2021
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
from
14705b4 to
215b70b
Compare
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
from
215b70b to
0b8d6f5
Compare
ptbrowne
reviewed
Mar 15, 2021
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
2 times, most recently
from
9c4c3f3 to
24fe278
Compare
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
6 times, most recently
from
9c45070 to
1015441
Compare
this is a fork from the original mui-bottom-sheet fork needed because of this issue : mayteio/mui-bottom-sheet#1
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
from
1015441 to
80c23a4
Compare
Crash--
reviewed
Mar 16, 2021
JF-Cozy
force-pushed
the
feat/bottomSheet-new
branch
from
80c23a4 to
c2d0657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sur mobile, pour les fichiers qui contiennent des informations "augmentée" (certification et konnecteur) on souhaite afficher ces informations dans un bottom sheet
La lib utilisée est https://github.com/mayteio/mui-bottom-sheet qui possède un bug mayteio/mui-bottom-sheet#1 . Nous avons donc forké https://github.com/cozy/mui-bottom-sheet pour corriger, c'est pourquoi nous utilisons notre propre version dans l'app.