Skip to content

Commit

Permalink
feat: Remove isListItem prop to ActionsMenuItems
Browse files Browse the repository at this point in the history
  • Loading branch information
Merkur39 committed Nov 28, 2024
1 parent b65fee1 commit 687b4f4
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/modules/actions/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export const openExternalLink = ({ t, isSharingShortcutCreated, link }) => {
},
Component: forwardRef(function OpenExternalLink(props, ref) {
return (
<ActionsMenuItem isListItem {...props} ref={ref}>
<ActionsMenuItem {...props} ref={ref}>
<ListItemIcon>
<Icon icon={icon} />
</ListItemIcon>
Expand Down
1 change: 0 additions & 1 deletion src/modules/drive/Toolbar/components/AddMenuItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const AddMenuItem = ({ onClick }) => {
return (
<ActionsMenuItem
ref={anchorRef}
isListItem
disabled={isDisabled || isOffline}
onClick={handleClick}
{...a11y}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const DownloadButtonItem = ({ files }) => {
}

return (
<ActionsMenuItem isListItem onClick={handleClick}>
<ActionsMenuItem onClick={handleClick}>
<ListItemIcon>
<Icon icon={DownloadIcon} />
</ListItemIcon>
Expand Down
6 changes: 1 addition & 5 deletions src/modules/drive/Toolbar/delete/DeleteItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ const DeleteItem = ({ t, isSharedWithMe, trashFolder, displayedFolder }) => {
const label = isSharedWithMe ? t('toolbar.leave') : t('toolbar.trash')

return (
<ActionsMenuItem
data-testid="fil-action-delete"
isListItem
onClick={handleClick}
>
<ActionsMenuItem data-testid="fil-action-delete" onClick={handleClick}>
<ListItemIcon>
<Icon icon={TrashIcon} color="var(--errorColor)" />
</ListItemIcon>
Expand Down
2 changes: 1 addition & 1 deletion src/modules/drive/Toolbar/selectable/SelectableItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const SelectableItem = ({ onClick }) => {
const { t } = useI18n()

return (
<ActionsMenuItem isListItem onClick={onClick}>
<ActionsMenuItem onClick={onClick}>
<ListItemIcon>
<Icon icon={CheckSquareIcon} />
</ListItemIcon>
Expand Down
2 changes: 1 addition & 1 deletion src/modules/drive/Toolbar/share/ShareItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const ShareItem = ({ displayedFolder }) => {
return (
<SharedDocument docId={displayedFolder.id}>
{({ isSharedWithMe, recipients, link }) => (
<ActionsMenuItem onClick={share} isListItem>
<ActionsMenuItem onClick={share}>
<ListItemIcon>
<Icon icon={ShareIcon} />
</ListItemIcon>
Expand Down
2 changes: 1 addition & 1 deletion src/modules/public/OpenExternalLinkItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const OpenExternalLinkItem = ({ link, isSharingShortcutCreated }) => {
})

return (
<ActionsMenuItem isListItem onClick={handleClick}>
<ActionsMenuItem onClick={handleClick}>
<ListItemIcon>
<Icon icon={icon} />
</ListItemIcon>
Expand Down

0 comments on commit 687b4f4

Please sign in to comment.