Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update io.cozy.identities.md #190

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update io.cozy.identities.md #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5af64e
Update io.cozy.identities.md
nicolasrenardcozy Feb 16, 2022
5095d29
Update io.cozy.identities.md
nicolasrenardcozy Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 41 additions & 6 deletions docs/io.cozy.identities.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ unique by identifier **and** cozyMetadata.createdByApp
"_id": "62e5d66d6e11d19992b7efce794263f0",
"identifier": "[email protected]",
"contact": {
"address": [
"addresses": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in favor of changing those keys. contact entry here, is the same as our io.cozy.contacts doctype. And in this doctype, we use the singular https://github.com/cozy/cozy-doctypes/blob/master/docs/io.cozy.contacts.md

Can we revert those changes? 🙏 .

{
"formattedAddress": "2 rue du moulin, 75000 Paris",
"street": "2 rue du moulin",
"postcode": "75000",
"city": "Paris"
}
"email": [
"emails": [
{
"address": "[email protected]",
}
Expand All @@ -37,22 +37,57 @@ unique by identifier **and** cozyMetadata.createdByApp
"familyName": "Dupond",
"givenName": "Jean"
},
"phone": [
"phones": [
{
"number": "06 06 06 06 06",
"primary": true,
"type": "mobile"
}
]
],
"maritalStatus": "married",
"numberOfDependants": 1
},
"tax_informations": [
{
"year": "2022",
"RFR": "56789.10",
"1AJ": "12345.67",
"1BJ": "23456.78",
"currency": "EUR",
"file": "avis_impot_2022.pdf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that the filename is useful since it can be renamed for instance. Can't we use a relationship here?

"tax_informations": [
    {
      "year": "2022",
      "RFR": "56789.10",
      "1AJ": "12345.67",
      "1BJ": "23456.78",
      "currency": "EUR",
      "relationship": {
           "type": "io.cozy.files", 
           "_id": XXX
       }

},
{
"year": "2021",
"RFR": "45678.91",
"1AJ": "34567.89",
"1BJ": "23456.78",
"currency": "EUR",
"file": "avis_impot_2022.pdf"
}
],
"revenues": [
{
"date": "2022-02-24",
"net_monthly_income": "1234.56",
"currency": "EUR" #si on l'a
"file": "fdp_022022.pdf"
}
],
"cozyMetadata": {
"doctypeVersion": 1,
"createdAt": "xxxxx",
"createdByApp": "orange",
"createdByAppVersion": "1.0.0",
"updatedAt": "xxxxx",
"updatedByApps": [ "orange" ],
"sourceAccount": "94263f062e5d66d6e11d19992b7efce7"
"updatedByApps": [
{
"date": "2021-11-23T10:36:49.752Z",
"slug": "connecteur",
"version": "1.12.4"
}
]
"sourceAccount": "XXXXXXXXXXXXX"
"sourceAccountIdentifier": "1234567891011",
}
}
```