Update MUI v4 #793
Merged
Update MUI v4 #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With MUI V4, it is possible to generate deterministic class names. In the case of multiple react roots, it is necessary to disable this feature. Since we have the cozy-bar root, we need to disable the feature. https://material-ui.com/styles/api/#stylesprovider Otherwise generated class names clash with others and some text become the wrong color during the usage of the app (especially visible on mobile).
ptbrowne
reviewed
Feb 16, 2021
| @@ -119,7 +119,7 @@ describe('ContactForm', () => { | |||
| } | |||
|
|
|||
| Object.keys(fields).forEach(fieldName => { | |||
| const candidates = form.find(`TextField[name='${fieldName}']`) | |||
| const candidates = form.find(`ForwardRef(TextField)[name='${fieldName}']`) | |||
There was a problem hiding this comment.
Mouais, OK, mais je pense qu'il faut plutot utiliser @testing-library/react dans ces cas là. C'est pas l'objet de la PR en soi, donc OK.
There was a problem hiding this comment.
Ok je fais une issue pour ne pas l'oublier : #795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message