fix: Creation of a contact when selecting a linked contact #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we wanted to create a new contact from the linked contact addition, the form component was rendered because the creation of the new contact triggers useQueries higher up the React tree. This re-rendering caused the form to lose any changes it had already made, such as adding the new linked contact.
BundleMonFiles updated (2)
Unchanged files (5)
Total files change +261B +0.01% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
reviewed
Nov 7, 2024
| contact: {} | ||
| } | ||
| expect(isSameContactProp(prevProps, nextProps)).toBe(false) | ||
| }) |
There was a problem hiding this comment.
I do not understand why we check only related things. It is because the only rerender that annoy us are when we created a related contact ?
There was a problem hiding this comment.
Returns are only due to the creation or update of contacts.
This can only happen directly by adding a linked contact, when we are in the creation form.
zatteo
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we wanted to create a new contact from the linked contact addition,
the form component was rendered because the creation of the new contact triggers useQueries higher up the React tree.
This re-rendering caused the form to lose any changes it had already made, such as adding the new linked contact.