Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix jsdocs in queryAll #1333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Fix jsdocs in queryAll #1333

wants to merge 1 commit into from

Conversation

LucsT
Copy link
Contributor

@LucsT LucsT commented Mar 17, 2023 •
edited by Crash--
Loading

The jsdoc concerning queryAll wasn't showing the correct return (Array of docs)

I propose this correction.
What do you think ?

@LucsT LucsT force-pushed the fix/cozyClientJsDoc branch from 43fcd74 to ef83ad0 Compare March 17, 2023 17:07
@LucsT LucsT force-pushed the fix/cozyClientJsDoc branch from ef83ad0 to cd44d0f Compare March 17, 2023 17:26
Crash--
Crash-- suggested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer QueryResult[] since CozyClientDocument[]` is about document, not JSON API related return.

There is a lot of work done in this #1234 in order to try to fix types issue.

@LucsT
Copy link
Contributor Author

LucsT commented Mar 20, 2023

@Crash--
Ok so you want me to add a commit in this PR instead with @returns {Promise<QueryResult[]>}
and close this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crash-- Crash-- Crash-- requested changes

@Merkur39 Merkur39 Awaiting requested review from Merkur39 Merkur39 is a code owner

@paultranvan paultranvan Awaiting requested review from paultranvan paultranvan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucsT @Crash--