Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block watcher metrics and last processed block #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: block watcher metrics and last processed block #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions src/services/chain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,11 @@ export class ChainContext {
log.debug(`Watchdog timeout: ${watchdogTimeout} seconds`);
let lastBlockReceived = lastProcessedBlock;
provider.on("block", async (blockNumber: number) => {
// Intentionally don't guard the getBlock call with a try/catch block
// because we want to crash the process if this fails. This will result
// in the kubernetes pod restarting and trying to recover.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would rephrase and not reference kubernetes here, as this is code that can be run in various ways

const block = await provider.getBlock(blockNumber);
try {
const block = await provider.getBlock(blockNumber);
log.debug(`New block ${blockNumber}`);

// Set the block time metric
Expand All @@ -352,23 +355,15 @@ export class ChainContext {
this
);

try {
await processBlock(this, block, events);

// Block height metric
this.registry.lastProcessedBlock = blockToRegistryBlock(block);
this.registry.write();
metrics.blockHeight.labels(chainId.toString()).set(blockNumber);
} catch {
log.error(`Error processing block ${blockNumber}`);
}

await processBlock(this, block, events);
log.debug(`Block ${blockNumber} has been processed`);
} catch (error) {
log.error(
`Error in pollContractForEvents for block ${blockNumber}`,
error
);
log.error(`Error processing block ${blockNumber}`, error);
} finally {
// Block height metric
this.registry.lastProcessedBlock = blockToRegistryBlock(block);
await this.registry.write();
metrics.blockHeight.labels(chainId.toString()).set(blockNumber);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if the block was not process, why should we write it is.
Wouldn't this cover up next issue we have?

}
});

Expand Down Expand Up @@ -445,6 +440,7 @@ export class ChainContext {
* @param events an array of conditional order created events
* @param blockNumberOverride to override the block number when polling the SDK
* @param blockTimestampOverride to override the block timestamp when polling the SDK
* @throws if there are any *unexpected errors* in processing the block
*/
async function processBlock(
context: ChainContext,
Expand Down
Loading