feat: uni list mapping #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Awesome! Nice you fixed the issues of typescript. I didn't see any TS related changes, how come this works now 🤯
Should you include some notes in the README on what this generates and how to run it?
It would be nice to describe there the general strategy to populate the lists.
Why some lists you print and some you don't?
| console.log(`🥇 ${logMessage} on chain ${chainId}`) | ||
|
|
||
| tokens.forEach((token, index) => { | ||
| const volumeStr = token.volume ? `: $${token.volume}` : '' |
There was a problem hiding this comment.
nit (just suggestion): since you are improving this, u could add https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat, as the volume was a bit hard to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uni map listing
Additionally: