Fix parsing of input and return empty solution #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
fhenneke
approved these changes
Sep 11, 2023
| "prices": {}, | ||
| "approvals": [], | ||
| "interaction_data": [], | ||
| "score": "0", |
There was a problem hiding this comment.
Fine for the workshop. Later on it might be useful to have an example solution which follows the correct format
| @@ -278,6 +278,7 @@ class AmmKindEnum(str, Enum): | |||
| CONSTANT_PRODUCT = "ConstantProduct" | |||
| WEIGHTED_PRODUCT = "WeightedProduct" | |||
| STABLE = "Stable" | |||
| CONCENTRATED = "Concentrated" | |||
There was a problem hiding this comment.
Is it already parsed into something? If not, this should be added at some point, see #19
There was a problem hiding this comment.
Univ3 is not supported here, and I think it's a bit out of scope, at least for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the parsing of instances and it also returns the empty solution.
Follow-up PR will add some very simple single-order solving.