Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concentrated Liquidity schema not defined. Returns "value is not a valid enumeration member" #19

Open
mohammed7s opened this issue Aug 29, 2022 · 3 comments

Comments

@mohammed7s
Copy link
Contributor

When attempting to run the solver-template-py with a recent live mainnet auction json, it returns a bunch of errors:

  • field required (type=value_error.missing)
  • value is not a valid enumeration member

This is because the uniswap class in uniswap.py and the schema.py have not defined this type of AMM yet.

@bh2smith
Copy link
Contributor

Great issue! Thanks for reporting. Any chance you'd like to submit a update to support such liquidity type?

@mohammed7s
Copy link
Contributor Author

Do you think the class Uniswap in uniswap.py, can handle it with some changes? Or you think a new class is needed altogether?

@bh2smith
Copy link
Contributor

Do you think the class Uniswap in uniswap.py, can handle it with some changes? Or you think a new class is needed altogether?

That is a great question. I am not familiar with this new liquidity type "concentrated liquidity" (my best guess is that it's a model for uniV3). Perhaps it's time for some new models here. cc @marcovc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants