Make block ranges consistent (take2) #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
reviewed
Jan 8, 2024
There was a problem hiding this comment.
I do like the approach with included start and end blocks better. It is way more intuitive to me. I would personally favor to include blocks on the start time and exclude blocks on the end time.
Regarding changing between to inequalities, one could even go with between everywhere. Since now we follow the SQL convention of in including the bounds. But being explicit is also fine.
Co-authored-by: Felix Henneke <[email protected]>
Co-authored-by: Felix Henneke <[email protected]>
|
@fhenneke Should we merge this? |
fhenneke
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based heavily on PR #329 but proposes a slightly different convention. Specifically, it assumes that we compute a
startandendblock for the accounting period, and bothstartandendblock are included in the accounting, as it seems more natural to the author.E.g., this means that for consecutive weeks, we have
week 1: [a,b]
week 2: [b+1, c]
week 3: [c+1, d]
etc.
All queries (except for the vouch registry one) have been updated in the form of forks. The plan would be to test this branch locally in the upcoming payouts of Jan 9, and compare results (or alternatively, use this branch in the dry-run script)
Once we are convinced that all changes are correct, we would then need to update the original Dune queries so that we continue using the same query ids.