Add missing transfers for sDAI deposits and withdraws #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks at event logs of the savings dai contract and adds a - AMM_IN transfers for Withdraw events - AMM_OUT transfers for Deposit events
harisang
reviewed
Dec 14, 2023
fhenneke
changed the title
|
I fixed some typos and added the pull request number. For completeness, here is a forked query on dune for the two affected auctions:
If this PR is merged, I will update
|
|
Looks good! Doing some sanity checks with settlements with sDAI for which we didn't have any accounting issues, and if things look good, will approve |
|
Here is an example where we seem to have a problem. |
|
Good catch. The problem was that the tranfer ledger should only contain transfers to and from the settlement contract. Thus it also only should add additional transfers for sDAI if the settlement contract is doing the trading. I added a check in the query. |
|
All tests that I ran checked out, and the code makes sense, so I am approving! |
harisang
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversions DAI<>sDAI are not correctly accounted for in the current slippage query. This has led to two settlements with computes slippage even though the slippage was actually small.
The reason is that
WithdrawandDepositevents are only accompanied by one transfer. But in terms buffer changes they correspond to two transfers.Tenderly and eigenphi get this wrong as well in their asset change calculations. To see what happens to buffers one can use phalcon or look at state changes.
With the proposed change, additional transfers are created by looking at event logs of the SavingsDAI contract.
Withdrawevent.Depositevent.This is not a general solution and only works for sDAI. Since we want to support that token now, I added this fix to the query.
Long term it would be nice to have a more general solution.