Driver sends flashloan hints #3244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
force-pushed
the
driver-sends-flashloan-tips
branch
from
7c64570 to
bac86c0
Compare
|
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
squadgazzz
commented
Jan 21, 2025
Comment on lines
+316
to
+328
| - fullBuyAmount | ||
| - validTo | ||
| - kind | ||
| - owner | ||
| - partiallyFillable | ||
| - preInteractions | ||
| - postInteractions | ||
| - sellTokenSource | ||
| - buyTokenDestination | ||
| - class | ||
| - appData | ||
| - signingScheme | ||
| - signature |
There was a problem hiding this comment.
Not related to this PR, but these are required in the code.
squadgazzz
commented
Jan 21, 2025
| @@ -727,6 +779,7 @@ components: | |||
| required: | |||
| - kind | |||
| - order | |||
| - executedAmount | |||
MartinquaXD
reviewed
Jan 21, 2025
squadgazzz
force-pushed
the
driver-sends-flashloan-tips
branch
from
400ebf3 to
4af3c34
Compare
# Conflicts: # crates/driver/src/domain/competition/order/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The follow-up to #3242, which implements #3216 by using the fetched
app-dataand sending flashloan hints to solver along with the order. The solver then returns a solution with an optionally attached flashloan data. Encoding of this data will be implemented in another PR(#3218).Changes
How to test
New driver tests. Backward compatibility is checked with all the existing and e2e tests.
Related Issues
Fixes #3216