Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rust 1.84.0 #3229

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Support rust 1.84.0 #3229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/autopilot/src/database/onchain_order_events/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,8 @@ type GeneralOnchainOrderPlacementData = (
OnchainOrderPlacement,
Order,
);
async fn parse_general_onchain_order_placement_data<'a>(
quoter: &'a dyn OrderQuoting,
async fn parse_general_onchain_order_placement_data(
quoter: &'_ dyn OrderQuoting,
order_placement_events_and_quotes_zipped: Vec<(EthContractEvent<ContractEvent>, i64, i64)>,
domain_separator: DomainSeparator,
settlement_contract: H160,
Expand Down
2 changes: 1 addition & 1 deletion crates/shared/src/sources/balancer_v2/swap/fixed_point/logexpmath.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ mod tests {
constant_x: fn(u32) -> I256,
constant_a: fn(u32) -> I256,
) {
let re = Regex::new(r".* ([ax])([\d]+) = (\d+);.*$").unwrap();
for line in code.split('\n').filter(|line| !line.trim().is_empty()) {
let re = Regex::new(r".* ([ax])([\d]+) = (\d+);.*$").unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy that there is a lint for compiling regexes in a loop. 😄 🚀

let cap = re.captures_iter(line).next().unwrap();
match &cap[1] {
"x" => assert_eq!(&cap[3], format!("{}", constant_x(cap[2].parse().unwrap()))),
Expand Down
Loading