Bad token detector metrics #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
added
the
hotfix
sunce86
approved these changes
Jan 9, 2025
MartinquaXD
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Because cached token quality information can expire these metrics will end up a bit unintuitive. Since we always increase the counter and never lower it we can only use it with a rate() function in grafana. I think this is fine to avoid making this more complex. Just wanted to point it out since this seems non-obvious.
Also half of these changes can be reverted with fact that the solver name is unreliable information for the simulation based metrics.
MartinquaXD
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Prometheus metrics for driver's bad token detector strategies, so it will be possible to show how many tokens were marked as
badby each solver and strategy. It would be helpful to identify solvers that perform as not expected and to analyze the work of each detection strategy individually.How to test
Create 2 grafana panels: the one that shows detected tokens by solver and another - by strategy.
Added
hotfixlabel to deploy it asap.