Driver sends quote response with JIT orders #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-orders-support # Conflicts: # crates/shared/src/trade_finding/external.rs
# Conflicts: # crates/shared/src/trade_finding/external.rs
# Conflicts: # crates/shared/src/trade_finding/external.rs
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
m-lord-renkse
approved these changes
Nov 27, 2024
MartinquaXD
reviewed
Dec 2, 2024
|
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
MartinquaXD
approved these changes
Dec 2, 2024
squadgazzz
added a commit
that referenced
this pull request
Dec 2, 2024
# Description Closes task n2 from #3082 by implementing support of the quotes with JIT orders in the trade verifier. For a gradual migration, it has to support both quote versions. # Changes - [ ] Added a new version of the trade with JIT orders. - [ ] Utilized the clearing prices to calculate the out amount. - [ ] Altered the `Solver.sol` helper contract to fetch all token balances as was proposed in [one of the comments](#3085 (comment)), which reduces the overall code complexity. - [ ] Bumped into an issue while converting floats into `BigRational`. ~~Implemented a workaround with converting float's string representation into `BigRational`.~~ Used `BigDecimal` in the config instead. ## How to test Unit tests. e2e would be possible only once the driver support is implemented(see #3103).
Base automatically changed from
3082/trade-verifier-jit-orders-support
to
main
December 2, 2024 13:18
# Conflicts: # crates/e2e/tests/e2e/quote_verification.rs # crates/shared/src/trade_finding/mod.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes task n3 from #3082 by start sending the new
/quoteresponse with the updated fields that include clearing prices instead of the executed amount, jit orders and pre-interactions.Changes
/quoteresponse which is now supported by the trade verifier.How to test
New driver's and services' e2e tests.