Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote with JIT orders API #3083

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Quote with JIT orders API #3083

merged 9 commits into from
Oct 28, 2024

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Oct 24, 2024

Description

Closes task n1 from #3082.

Introduces a new version of the driver's /quote response in the API schema in order to support a gradual migration to the quote with jit orders making the changes backward compatible.

The driver changes are expected in the future PRs.

Changes

Update the driver's OpenAPI schema quote object with an enum with the old and new versions. Trade verifier returns error in case a new version is received.

How to test

Existing tests. I was thinking about how to test it properly, but it still requires e2e tests. So, it should be implemented in the next PRs.

@squadgazzz squadgazzz requested a review from a team as a code owner October 24, 2024 17:20
crates/driver/openapi.yml Outdated Show resolved Hide resolved
crates/driver/openapi.yml Show resolved Hide resolved
crates/driver/openapi.yml Show resolved Hide resolved
crates/shared/src/trade_finding/external.rs Outdated Show resolved Hide resolved
crates/shared/src/trade_finding/external.rs Outdated Show resolved Hide resolved
crates/shared/src/trade_finding/external.rs Show resolved Hide resolved
crates/driver/openapi.yml Outdated Show resolved Hide resolved
crates/driver/openapi.yml Show resolved Hide resolved
@squadgazzz squadgazzz enabled auto-merge (squash) October 28, 2024 12:36
@squadgazzz squadgazzz disabled auto-merge October 28, 2024 12:45
@squadgazzz squadgazzz merged commit f808db2 into main Oct 28, 2024
11 checks passed
@squadgazzz squadgazzz deleted the 3082/jit-orders-quote-api branch October 28, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants