Release/2.19.0 #396

nenadV91 · 2023-03-21T11:53:11Z

Summary

Release 2.19.0

SDK dogfooding SDK dogfooding #391
Update Dune analytics link Update dune analytics link #395
Some dependencies version bumps

Bumps [eslint-plugin-storybook](https://github.com/storybookjs/eslint-plugin-storybook) from 0.6.10 to 0.6.11. - [Release notes](https://github.com/storybookjs/eslint-plugin-storybook/releases) - [Changelog](https://github.com/storybookjs/eslint-plugin-storybook/blob/main/CHANGELOG.md) - [Commits](storybookjs/eslint-plugin-storybook@v0.6.10...v0.6.11) --- updated-dependencies: - dependency-name: eslint-plugin-storybook dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…lop/eslint-plugin-storybook-0.6.11 Bump eslint-plugin-storybook from 0.6.10 to 0.6.11

Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.5.15 to 6.5.16. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.16/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.5.16/addons/links) --- updated-dependencies: - dependency-name: "@storybook/addon-links" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/app/react) from 6.5.15 to 6.5.16. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/v6.5.16/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.5.16/app/react) --- updated-dependencies: - dependency-name: "@storybook/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 16.9.17 to 16.9.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.15.4 to 1.15.5. - [Release notes](https://github.com/bahmutov/start-server-and-test/releases) - [Commits](bahmutov/start-server-and-test@v1.15.4...v1.15.5) --- updated-dependencies: - dependency-name: start-server-and-test dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [playwright](https://github.com/Microsoft/playwright) from 1.30.0 to 1.31.1. - [Release notes](https://github.com/Microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.30.0...v1.31.1) --- updated-dependencies: - dependency-name: playwright dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* SDK dogfooding * Webpack config * Fix vercel build * 😭 * Fix appData page * fix subgraphApiSDK URLs

vercel · 2023-03-21T11:53:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
explorer-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback

📖 Storybook ↗︎

socket-security · 2023-03-21T11:55:49Z

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package	Script field	Source
[email protected] (upgraded)	`install`	`package.json`

Pull request report summary

Issue	Status
Install scripts	⚠️ 1 issue
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore [email protected]

Powered by socket.dev

coveralls · 2023-03-21T11:57:08Z

Pull Request Test Coverage Report for Build 4490305362

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 60.226%

Totals
Change from base Build 4325641785:	-0.2%
Covered Lines:	833
Relevant Lines:	1200

💛 - Coveralls

elena-zh · 2023-03-21T17:39:09Z

Hey @nenadV91 , the PR looks good to me!
Just it would be great to merge #397 fix into the current PR.
I reported #398 issue that is related to the current release changes that might be addresses later.
And have 1 question: now data does not match in the Prod and Barn Explorers, however, it should. Besides, a native token is missing in the Barn Explorer (in the current PR as well). I reported #399 issue for this.
Is this something that might be connected to the SDK-dogfooding changes? If yes, I'm not in favor of releasing the current changes.
Thanks!

* Fix some app data page issues * Remove log

nenadV91 · 2023-03-23T09:02:44Z

@elena-zh #397 is merged and for #399 I think @tukantje is looking into this one.

anxolin · 2023-03-23T10:46:24Z

src/cowSdk.ts

+}
+
+export const prodOrderBookSDK = new OrderBookApi({ env: 'prod' })
+export const stagingOrderBookSDK = new OrderBookApi({ env: 'staging' })


I guess its fine, although I think one instance should be fine.
There's a parameter in every call to be able to override the env if necessary

dependabot bot and others added 10 commits February 27, 2023 03:18

Merge pull request #361 from cowprotocol/dependabot/npm_and_yarn/deve…

4d447be

…lop/eslint-plugin-storybook-0.6.11 Bump eslint-plugin-storybook from 0.6.10 to 0.6.11

Merge branch 'main' into develop

6ad6100

Merge branch 'main' into develop

e4f125a

SDK dogfooding (#391)

4fc9a3a

* SDK dogfooding * Webpack config * Fix vercel build * 😭 * Fix appData page * fix subgraphApiSDK URLs

nenadV91 and others added 2 commits March 21, 2023 12:53

Update dune analytics link (#395)

5a02da5

Version 2.19.0 bump

a7376f1

vercel bot deployed to Preview March 21, 2023 12:04 View deployment

vercel bot deployed to Preview March 21, 2023 12:13 View deployment

nenadV91 force-pushed the release/2.19.0 branch from 1e0cb98 to b21e359 Compare March 21, 2023 12:19

vercel bot deployed to Preview March 21, 2023 12:21 View deployment

nenadV91 force-pushed the release/2.19.0 branch from b21e359 to a7376f1 Compare March 21, 2023 12:27

nenadV91 requested review from a team March 21, 2023 12:30

elena-zh mentioned this pull request Mar 21, 2023

AppData: UI issues with Order Class section #398

Closed

Fix some app data page issues (#397)

3e310ff

* Fix some app data page issues * Remove log

vercel bot deployed to Preview March 22, 2023 13:24 View deployment

elena-zh approved these changes Mar 23, 2023

View reviewed changes

alfetopito approved these changes Mar 23, 2023

View reviewed changes

anxolin approved these changes Mar 23, 2023

View reviewed changes

nenadV91 merged commit f7bec32 into main Mar 23, 2023

nenadV91 deleted the release/2.19.0 branch May 4, 2023 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/2.19.0 #396

Release/2.19.0 #396

nenadV91 commented Mar 21, 2023

vercel bot commented Mar 21, 2023 •

edited by github-actions bot

Loading

socket-security bot commented Mar 21, 2023 •

edited

Loading

coveralls commented Mar 21, 2023 •

edited

Loading

elena-zh commented Mar 21, 2023

nenadV91 commented Mar 23, 2023

anxolin Mar 23, 2023

Release/2.19.0 #396

Release/2.19.0 #396

Conversation

nenadV91 commented Mar 21, 2023

Summary

vercel bot commented Mar 21, 2023 • edited by github-actions bot Loading

socket-security bot commented Mar 21, 2023 • edited Loading

Socket Security Pull Request Report

coveralls commented Mar 21, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4490305362

💛 - Coveralls

elena-zh commented Mar 21, 2023

nenadV91 commented Mar 23, 2023

anxolin Mar 23, 2023

Choose a reason for hiding this comment

vercel bot commented Mar 21, 2023 •

edited by github-actions bot

Loading

socket-security bot commented Mar 21, 2023 •

edited

Loading

coveralls commented Mar 21, 2023 •

edited

Loading