136 add goerli 2

[alfetopito]

Summary

Closes #136

Based on/supersedes #170

Rebased against latest develop because I needed changes there, so have diverged from original.
You can see what changes have been added by looking from this commit onwards 299f475

Fixes

• AppData loading on order details
• Multi env queries (prod on barn and vice versa)
• Contract address for goerli

[coveralls]

Pull Request Test Coverage Report for Build 2882544587

• 7 of 9 (77.78%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.07%) to 43.824%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/state/network/updater.tsx	1	2	50.0%
src/utils/miscellaneous.ts	1	2	50.0%

Totals
Change from base Build 2839489960:	-0.07%
Covered Lines:	2158
Relevant Lines:	4174

---

💛 - Coveralls

[github-actions]

• 🔭 Explorer: Explorer test app
• 🔒 Safe Swap App: Trade test app (add to your safe apps)
• 📈 Trade: Trade test app
• 📚 Storybook: Component stories

[elena-zh]

Hey @alfetopito , changes LGTM!
However, I still see that environments are mixed up: I see orders placed in Prod/Staging in the PR link, and do not see them when I place orders from Barn/Dev/pr

Could you please fix it?

Thanks!

[ramirotw]

Hey @alfetopito , changes LGTM! However, I still see that environments are mixed up: I see orders placed in Prod/Staging in the PR link, and do not see them when I place orders from Barn/Dev/pr

Could you please fix it?

Thanks!

@elena-zh wasn't the User Details orders locked to prod-only orders on purpose? I couldn't find the issue in the sdk to handle this case where we merge paginated responses from the api so I created a new one (cowprotocol/cow-sdk#72).

[elena-zh]

@alfetopito , User details show orders from Prod/Staging in

• https://explorer.cow.fi/
• https://protocol-explorer.staging.gnosisdev.com/

And orders from Barn/Dev/PR in

• https://protocol-explorer.dev.gnosisdev.com/
• https://barn.cowswap.exchange/#/swap?chain=rinkeby
• Explorer PR links

I have retested it now, and it works like I describe in https://explorer.cow.fi/ and in https://protocol-explorer.dev.gnosisdev.com/: https://watch.screencastify.com/v/hjxqD3d1q0PN95Xx34H0 .

But in the current PR I see orders from Prod/Staging, and completely to not see orders from Barn/Dev/PR

I do not know why it happens either, but if it works differently that we currently have in stable environments, I report this.

As for pagination issue, we decided not to show all orders from Prod and Barn in user details page, and show orders like it is currently works and I have described in the 1st part of my message.

[alfetopito]

@alfetopito , User details show orders from Prod/Staging in

* https://explorer.cow.fi/

* https://protocol-explorer.staging.gnosisdev.com/

And orders from Barn/Dev/PR in

* https://protocol-explorer.dev.gnosisdev.com/

* https://barn.cowswap.exchange/#/swap?chain=rinkeby

* Explorer PR links

I have retested it now, and it works like I describe in https://explorer.cow.fi/ and in https://protocol-explorer.dev.gnosisdev.com/: https://watch.screencastify.com/v/hjxqD3d1q0PN95Xx34H0 .

But in the current PR I see orders from Prod/Staging, and completely to not see orders from Barn/Dev/PR

I do not know why it happens either, but if it works differently that we currently have in stable environments, I report this.

As for pagination issue, we decided not to show all orders from Prod and Barn in user details page, and show orders like it is currently works and I have described in the 1st part of my message.

You are right to point this out Elena.

Without looking into this very deeply, I assume that what is happening is this:

1. On the SDK, we now default to querying PROD, unless otherwise specified with a parameter
2. Since we are not querying both envs for paginated queries, it'll only call PROD
3. Probably (haven't checked the code yet) the query for user orders does not have the env parameter set, thus it's always querying PROD

[alfetopito]

wasn't the User Details orders locked to prod-only orders on purpose?

And replying to Ramiro, user details should reflect the environment we are at, as I don't recall we decided to make it PROD only.

Thus, barn should show barn orders (same for local and PRs) while the rest should show prod orders

[ramirotw]

@elena-zh @alfetopito nice catch both! When I refactored the code I didn't include the prod/barn switch for user orders, so it was always defaulting to prod. Now it should work as before.

[elena-zh]

LGTM!