Fix order search in different networks

[ramirotw]

Summary

Close #130
Close #138

To Test

1. Copy an orderID from Rinkeby
2. Switch to Gnosis chain
3. Navigate to the Home page
4. Search for the copied order

[github-actions]

• 🔭 Explorer: Explorer test app
• 🔒 Safe Swap App: Trade test app (add to your safe apps)
• 📈 Trade: Trade test app
• 📚 Storybook: Component stories

[coveralls]

Pull Request Test Coverage Report for Build 2538512083

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.004%) to 43.876%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/services/helpers/tryGetOrderOnAllNetworks.ts	8	11	72.73%

Totals
Change from base Build 2511347940:	0.004%
Covered Lines:	2164
Relevant Lines:	4181

---

💛 - Coveralls

[ramirotw]

@elena-zh re-posting here your feedback from #130 (comment)

Hey @ramirotw , great changes!
However, I have noticed, that order TxHash does not appear when open a transaction for the 1st time using search in a different network. See the video: https://watch.screencastify.com/v/nuo4Q7xONKJ608sQ1UTj (the issue itself starts from 25s on the video)
Could you please take a look into this issue?

[elena-zh]

seems that the fix was reverted

[matextrem]

LGTM 👍

[henrypalacios]

It does not work for me!

When I search on GC the tx 0x5dd8cab9849abc9ff04230d3c7432fa9206fd5b47fd5cb704bc04775f4ec65a2b638eda8c10005cb456b1913ad60a8f3d6a927146144b0ea I got 👇

It's a valid order on mainnet

[elena-zh]

Hey @ramirotw , I can't load a TX details page when I search for Rinkeby transaction in Ethereum. See the video: https://watch.screencastify.com/v/DRq2z7sKeGORMI8qYDeT

Refreshing the page helps, though.

Could you please take a look at it?

Here were my steps:

1. Open user details in Rinkeby
2. Copy an order ID from the list
3. Open Home page in Ethereum
4. Search for a copied order ID

[ramirotw]

Hey @ramirotw , I can't load a TX details page when I search for Rinkeby transaction in Ethereum. See the video: https://watch.screencastify.com/v/DRq2z7sKeGORMI8qYDeT

This was caused by the hook that fetches the tokens. The tokens fetch was triggered while still on the mainnet and set a loading flag to true, but when on rinkeby it didn't re-run, so it stayed on loading indefinitely.

[elena-zh]

Hey @ramirotw !
The issue is partially fixed, as search for:

• Rinkeby orderID in GC- works fine
• Mainnet orderID in GC - works fine
• GC orderID in Rinkeby - works fine.
  BUT search for
• GC orderID in Mainnet - not working
• Rinkeby orderID in Mainnet- not working
• Mainnet orderID in Rinkeby - not working
  See the video: https://watch.screencastify.com/v/LAveDbxnR9O13dOGmDnh

Besides, I have found a strange issue with orders list pagination in this Pr: https://watch.screencastify.com/v/YSoUCU7TRfQcyJ0yElph

Thanks!

[elena-zh]

@ramirotw , search for orders IDs look good to me now!

However, amounts for TX details are not loaded in this PR when search for transactions from different networks. Could you please take a look at it, as the issue is not reproducible in #137

[elena-zh]

@ramirotw , search for orders IDs look good to me now!

However, amounts for TX details are not loaded in this PR when search for transactions from different networks. Could you please take a look at it, as the issue is not reproducible in #137

Steps to reproduce it:

1. Copy a Tx hash of a filled order in Gnosis chain
2. Open Home page in Ethereum
3. Paste the copied TxHash from GC into the search field and search for it.

AR: Tx details page is opened, but amounts are not loaded

[ramirotw]

@elena-zh please re-test

[elena-zh]

@ramirotw , order search does not work at all (order from a different network)

Transaction search, pagination LGTM!

[ramirotw]

@ramirotw , order search does not work at all (order from a different network)

A commit didn't apply while rebasing 🤦‍♂️, my bad sorry

[elena-zh]

@ramirotw , changes LGTM now!