Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

User details: pagination issues when orders from Barn/Prod API are requested #149

Closed
elena-zh opened this issue Jun 28, 2022 · 0 comments · Fixed by #245
Closed

User details: pagination issues when orders from Barn/Prod API are requested #149

elena-zh opened this issue Jun 28, 2022 · 0 comments · Fixed by #245
Assignees
Labels
app:Explorer Explorer App Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system
Milestone

Comments

@elena-zh
Copy link

elena-zh commented Jun 28, 2022

Originally reported in #132 (comment)

Orders list pagination does not work as expected. See the video: https://watch.screencastify.com/v/YSoUCU7TRfQcyJ0yElph

The issue was introduced by merging of the responses of user orders by env. So the old way of paginating doesn't work correctly as the orders can be either in the prod or barn api, or both, so the logic to know if there's more data to move to the next page is wrong.

Possible options how to resolve the issue:

  1. Add an endpoint for pagination
  2. Add an option to a user to select what orders to see (from Barn/Prod APIs), then show orders according to a selected option (no changes to pagination)
@elena-zh elena-zh added app:Explorer Explorer App Enhancement New feature or request Medium Protofire labels Jun 28, 2022
@ramirotw ramirotw modified the milestones: 2.10.0, 2.11.0 Jul 14, 2022
@elena-zh elena-zh added Low Severity indicator for defects. It won't cause any major break-down of the system and removed Medium labels Jul 22, 2022
@ramirotw ramirotw modified the milestones: 2.13.0, 2.14.0 Sep 19, 2022
@ramirotw ramirotw modified the milestones: 2.14.0, 2.15.0 Oct 19, 2022
@ramirotw ramirotw self-assigned this Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Enhancement New feature or request Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants