-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network alert (only for gchain for now) #505
Conversation
Using instead theme colors
CLA Assistant Lite All Contributors have signed the CLA. |
|
Hey @alfetopito , nice changes! I think, it would be great to hide this message when connected to an unsupported network. Then, I think it would be nice to add a 'hover' effect to the banner (highlight links or so). WDYT? |
@elena-zh should be fixed, please try again once the build finishes |
Hey @alfetopito , great! However, I have noticed that only in this PR I have started to see 'Hang in here..' message when switching back from an unsupported network to a supported one. Please, follow these steps to reproduce the issue:
As for the hover effect, could we please change its color to orange as we do on the 'Profile' page for cards? Thanks! |
Hmmm, that's weird. |
In any way, that issue is definitely not related to the PR at hand and should be addressed separately. |
@alfetopito , hm. I retested it in #502 PR, but it was not reproducible there. So I thought that it was related to the current PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Merging as is, @fairlighteth feel free to post merge review |
Summary
Fixing network alert for gchain
From
To
To Test