Fix broken docs #230
Merged
Fix broken docs #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
reviewed
Jan 6, 2025
| @@ -60,6 +61,7 @@ | |||
| "@typescript-eslint/parser": "^5.51.0", | |||
| "babel-plugin-inline-import": "^3.0.0", | |||
| "coveralls": "^3.1.1", | |||
| "cpx": "^1.5.0", | |||
There was a problem hiding this comment.
Why cpx rather than pure cp?
AFACIT, cpx would be useful for watching file changes, but that's not needed here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link breaks the docs
This fix has been tested. Uses absolute path, which is not ideal but works. I will merge this to fix the docs. We might want to reiterate.
Maybe one better solution is to move the trading SDK docs to the official documentation