Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace the usage of executedSurplusFee with executedFee #229

Merged
merged 3 commits into from
Dec 30, 2024
Merged

feat: replace the usage of executedSurplusFee with executedFee #229

merged 3 commits into from
Dec 30, 2024

Conversation

alfetopito
Copy link
Contributor

Summary

As part of backend's fee overhaul, executedSurplusFee is deprecated in favor of executedFee.

This change replaces it where applicable, as well as building the types based on the latest backend release that includes such changes https://github.com/cowprotocol/services/releases/tag/v2.291.0

Testing

  • Unit tests
  • Locally loaded it via yalc on CoW Swap/Explorer

@alfetopito alfetopito self-assigned this Dec 30, 2024
@alfetopito alfetopito requested a review from a team December 30, 2024 17:16
@coveralls
Copy link
Collaborator

coveralls commented Dec 30, 2024 •
edited
Loading

Coverage Status

coverage: 78.378%. remained the same
when pulling 125b868 on feat/executedFee
into 7658e39 on main.

@socket-security Socket Security
Copy link

Report too large to display inline

View full report↗︎

@alfetopito alfetopito mentioned this pull request Dec 30, 2024
Merged
@alfetopito alfetopito merged commit 6d77cfe into main Dec 30, 2024
14 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
@alfetopito alfetopito deleted the feat/executedFee branch December 31, 2024 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @coveralls @anxolin