Refactor stop-loss create just 1 discrete order

[yvesfracari]

Description

• Avoid multiple discrete order creations for one stop-loss order creation.

Changes

• Replace the validityBucketTime parameter of stop loss data with constant validTo.

How to test

1. Run the modified local test.
2. Try to create multiple discrete orders from the same stop-loss order using the deployed contract on sepolia: 0xe6CDbC068654C506424F7747357F51d0e7caB00e

[fedgiac]

The changes look good, but why was it previously implemented in bucket?
My only guess is that maybe long-lived orders aren't accepted by the API. In case, has this changed?

[fedgiac]

It would be better if there was also a test that shows an order is valid if warping to validTo, all other tests use type(uint256).max for the valid to so the positive boundary condition isn't tested on a different number.

[mfw78]

The changes look good, but why was it previously implemented in bucket? My only guess is that maybe long-lived orders aren't accepted by the API. In case, has this changed?

Because I was foolish when I implemented it 🙈 This was the last conditional order type that I added "last minute". Never do things "last minute" it seems 🤦‍♂️

[mfw78]

Concur with the review comments from @fedgiac

[yvesfracari]

@mfw78 once this is merged, let us know if we should deploy this contract on all chains or you will do it.