Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: revert with more than 4bytes #78

Merged
merged 3 commits into from
Oct 1, 2023
Merged

tests: revert with more than 4bytes #78

merged 3 commits into from
Oct 1, 2023

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Oct 1, 2023

Description

The current test suite only allows for testing settlements that may revert with only a 4bytes selector (ie. no parameterized). This PR remedies that.

Changes

  • Abstract revert data can be asserted with settle in the test harness.
  • Standardises the use of hex"" for hex literal strings / empty bytes.
  • Gardening to dry some test of the test harness.

How to test

  1. forge test -vvv --optimizer-runs 200 --no-match-test "fork|simulate" --fuzz-seed 672679878

@mfw78 mfw78 self-assigned this Oct 1, 2023
@mfw78 mfw78 added test Issue related to the test suite with no expected consequence to production code E:1.1: Conditional Order Templates https://github.com/cowprotocol/pm/issues/1 labels Oct 1, 2023
@mfw78
Copy link
Contributor Author

mfw78 commented Oct 1, 2023

As this PR is only related to the test harness with a narrow scope on increasing the usability of settle, with all tests in CI/CD passing, will merge to develop without waiting for review approvals.

@mfw78 mfw78 requested review from fleupold and fedgiac October 1, 2023 04:40
@mfw78 mfw78 merged commit bee4616 into develop Oct 1, 2023
2 checks passed
@mfw78 mfw78 deleted the fix-revert-gt-4bytes branch October 1, 2023 04:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E:1.1: Conditional Order Templates https://github.com/cowprotocol/pm/issues/1 test Issue related to the test suite with no expected consequence to production code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant