feat: watch tower / sdk friendly expanded interface #73
Conversation
src/types/twap/TWAP.sol
Outdated
| * @inheritdoc IConditionalOrder | ||
| */ | ||
| function validateData(bytes memory data) external override pure { | ||
| TWAPOrder.validate(abi.decode(data, (TWAPOrder.Data))); |
There was a problem hiding this comment.
Cool, you now expose this function, but shouldn't you use the new Errors in TWAP too?
There was a problem hiding this comment.
The intent was to not change existing contracts, however, as the interface enforces this, I'll add the changes to TWAP, but remove the deployment addresses in README.md as the changes are not reflective of what is deployed (and we need to be careful and ensure we don't merge these into main unless there is a clear intent to have the changes audited).
tl;dr I don't think it's reasonable to count on these changes being usable in production at the moment until such time in the future that there are additional order types / tweaks that necessitate a new audit / review. It's fine however for new conditional orders to use these tweaks straight up.
Incentives research is tracked here. |
mfw78
force-pushed
the
feat-interface-learnings
branch
from
7420aa7 to
bc089b2
Compare
mfw78
added
E:1.2: Watch Tower Service
Description
Provides expanded
IConditionalOrderinterfaces with parameterized errors as these are required to standardise such that the conditional order is able to communicate it's indexing intent to a watch tower.Changes
validateDataexternal function for verifying a conditional order's data struct if granular verification has been implemented (recommended for order type developers).How to test
The TWAP contract has been updated to implement the expanded interface. To test:
forge testRelated Issues
Fixes #72