-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chunked multicalls, more logs, memory snapshots, nuke explorer apis #17
Open
meetmangukiya
wants to merge
7
commits into
main
Choose a base branch
from
logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
reviewed
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, although this could easily be three separate PRs (I'm also not sure if we actually want to check in the memory snapshots)
mfw78
reviewed
May 21, 2024
mfw78
approved these changes
May 22, 2024
Co-authored-by: mfw78 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pino
logMemory
will log memory in debug levelTrade
logs. The block explorer APIs return a lot of tokens(99% of which are airdropped shitcoins). We used to have a usd based filter earlier that filtered most of them out, but we removed that in 76d4d1c in Address review comments #11. ATM the ethplorer api returns like 7k tokens, it then goes on to request quote from the cow api for all of them which led to it using a lot of memory (6GB+) and taking too long(because of the rate limiter with exponential backoff logic). On the other hand, thechain
strategy executed successfully in 6 minutes and has no dependency on external block explorer APIs and just requires querying the chain forTrade
events.