Suggesting a fix to the platformclient so a region can be specified t… #40
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the push and platform API URL
rweeber-coveo
requested review from
olamothe,
fpbrault and
alexprudhomme
and removed request for
a team
|
The build failed due to something I think related to this bug: pypa/setuptools#4483. It's not something I can address on my end. |
|
Hi @rweeber-coveo , if you can look at why the CI is failing and fix that in another PR, that'd be much appreciated. |
alexprudhomme
requested changes
Oct 30, 2024
Comment on lines
-190
to
+191
| return f'https://api.cloud.coveo.com/push/v1/organizations/{self.organizationid}' | ||
| return f'https://api-{self.region}.cloud.coveo.com/push/v1/organizations/{self.organizationid}' |
There was a problem hiding this comment.
I don't think https://api-us.cloud.coveo.com/push/v1/organizations/ is equal to https://api.cloud.coveo.com/push/v1/organizations/.
I can't find mentions of -us
https://docs.coveo.com/en/2976/manage-an-organization/deployment-regions-and-strategies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to review a simple fix to the platformclient.py and source.py classes that allow for a region parameter to be passed into the constructor. There is a default constructor value for region so that existing adoption of the SDK will continue to function. This is not a breaking change.