Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(actions): target ubuntu-latest explicitely when running depency-review [DT-7006] #154

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

jonapich
Copy link
Member

feat: **Target ubuntu-latest directly when running dependency-review **

https://coveord.atlassian.net/browse/DT-7006

Summary of changes:

  • The dependency-review workflow now targets ubuntu-latest directly instead of using the default.

We are changing the default value of the dependency-review action to target our self-hosted runners.
Therefore, public repositories must be adjusted prior else they will not be able to run the workflow anymore.

You should adjust and merge this pull request yourself if you're OK with it.
Feel free to comment if there's an issue!

feat: **Target ubuntu-latest directly when running dependency-review **

https://coveord.atlassian.net/browse/DT-7006

Summary of changes:
  - The `dependency-review` workflow now targets `ubuntu-latest` directly instead of using the default.

We are changing the default value of the `dependency-review` action to target our self-hosted runners.
Therefore, public repositories must be adjusted prior else they will not be able to run the workflow anymore.

*You should adjust and merge this pull request yourself if you're OK with it.
Feel free to comment if there's an issue!*
@jonapich jonapich requested a review from a team as a code owner July 16, 2024 09:42
@jonapich jonapich requested review from olamothe, fbeaudoincoveo, alexprudhomme, dblanchette and a team and removed request for a team July 16, 2024 09:42
@jonapich jonapich changed the title Target ubuntu-latest explicitely when running depency-review [DT-7006] refactor(actions): Target ubuntu-latest explicitely when running depency-review [DT-7006] Jul 16, 2024
@jonapich jonapich changed the title refactor(actions): Target ubuntu-latest explicitely when running depency-review [DT-7006] refactor(actions): target ubuntu-latest explicitely when running depency-review [DT-7006] Jul 16, 2024
@jonapich jonapich changed the title refactor(actions): target ubuntu-latest explicitely when running depency-review [DT-7006] refactor(actions): target ubuntu-latest explicitely when running depency-review dt-7006 Jul 16, 2024
@jonapich jonapich changed the title refactor(actions): target ubuntu-latest explicitely when running depency-review dt-7006 refactor(actions): target ubuntu-latest explicitely when running depency-review [DT-7006] Jul 16, 2024
@alexprudhomme alexprudhomme enabled auto-merge (squash) July 16, 2024 11:18
@alexprudhomme alexprudhomme enabled auto-merge (squash) July 16, 2024 11:25
@alexprudhomme alexprudhomme merged commit c27e75d into main Jul 16, 2024
5 checks passed
@samisayegh samisayegh deleted the feature/DT-7006-dependency-review-ubuntu-latest branch July 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants