Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only diff json files #1323

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: only diff json files #1323

merged 2 commits into from
Oct 10, 2023

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Sep 13, 2023

https://coveord.atlassian.net/browse/CDX-1481

Proposed changes

Only perform detailed diff on JSON files.

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

@y-lakhdar y-lakhdar requested a review from a team as a code owner September 13, 2023 16:54
@y-lakhdar y-lakhdar requested review from olamothe, louis-bompart and mrrajamanickam-coveo and removed request for a team September 13, 2023 16:54
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 0522225.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Manifest Files

@github-actions
Copy link
Contributor

Thanks for your contribution @y-lakhdar !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@y-lakhdar y-lakhdar enabled auto-merge (squash) September 18, 2023 15:34
@y-lakhdar y-lakhdar merged commit ae1361a into master Oct 10, 2023
32 checks passed
@y-lakhdar y-lakhdar deleted the CDX-1481 branch October 10, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants