feat: track database modifications, incremental updates #335
+653
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol need to untrack some files |
bearsyankees
force-pushed
the
last-mod
branch
from
7cda0bf
to
fafe34c
Compare
Josh-Cena
changed the title
Josh-Cena
reviewed
Oct 30, 2024
ferry/database/diff_db.py
Outdated
Comment on lines
68
to
69
| old_value = ast.literal_eval(str(old_value).replace('"',"'")) # fix quotes | ||
| new_value = ast.literal_eval(str(new_value).replace('"',"'")) |
There was a problem hiding this comment.
I'm pretty sure that strings in DB are JSON, not Python literals, so you can just use ujson.loads instead of ast.literal_eval. Also only perform the parsing if the value isn't already a list
|
Hey! FYI there are three new tables in e5171dd — |
Thanks! will update |
|
lets DOOOO ITTTTTT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #303
Part of coursetable/coursetable#1656