feat: update to latest ibc spec and use latest ibc-go eureka simapp in e2e #88

gjermundgaraba · 2024-11-11T10:26:03Z

No description provided.

…sion-of-ibc-go-with-eureka

gjermundgaraba · 2024-11-11T10:26:39Z

e2e/interchaintestv8/chainconfig/chain_config.go

@@ -15,7 +15,7 @@ var DefaultChainSpecs = []*interchaintest.ChainSpec{
 			Images: []ibc.DockerImage{
 				{
 					Repository: "ghcr.io/cosmos/ibc-go-wasm-simd", // FOR LOCAL IMAGE USE: Docker Image Name
-					Version:    "poc-solidity-ibc-eureka-wasm",    // FOR LOCAL IMAGE USE: Docker Image Tag
+					Version:    "gjermund-tmp-wasmd",              // FOR LOCAL IMAGE USE: Docker Image Tag


Will update to a more proper version soon, waiting for some PRs

gjermundgaraba · 2024-11-11T10:27:28Z

e2e/interchaintestv8/chainconfig/encoding.go


-	wasmtypes "github.com/CosmWasm/wasmd/x/wasm/types"


wasmd types not compatible, which is why we have our own types I guess

codecov · 2024-11-11T11:26:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (54d509b) to head (0000000).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   98.52%   98.59%   +0.07%     
==========================================
  Files          12       12              
  Lines         338      357      +19     
  Branches       11       11              
==========================================
+ Hits          333      352      +19     
  Misses          5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

srdtrk

Looking good. I'll approve after most of the review items are addressed. Can you also update the benchmarks in README?

src/errors/IICS26RouterErrors.sol

src/utils/ICS24Host.sol

src/ICS20Transfer.sol

src/msgs/IICS26RouterMsgs.sol

src/utils/ICS24Host.sol

Co-authored-by: srdtrk <[email protected]>

…sion-of-ibc-go-with-eureka

gjermundgaraba · 2024-11-12T10:17:16Z

@srdtrk updated with the changes now

…sion-of-ibc-go-with-eureka

srdtrk

Lgtm. I left a few nits which I'll push myself and then merge this PR

test/fixtures/acknowledgePacket-groth16.json

test/fixtures/acknowledgePacket-plonk.json

test/fixtures/receivePacket-groth16.json

test/fixtures/receivePacket-plonk.json

src/utils/ICS24Host.sol

srdtrk · 2024-11-13T01:38:43Z

src/utils/ICS20Lib.sol

+    /// @notice ICS20_ENCODING is the encoding string for ICS20 packet data.
+    string public constant ICS20_ENCODING = "application/json";


Can't wait to test this with abi encoding in the future 🚀

srdtrk · 2024-11-13T03:10:00Z

I've also updated the benchmarks

AdityaSripal · 2024-11-12T14:00:50Z

src/ICS20Transfer.sol

+            value: packetData
+        });
+        IICS26RouterMsgs.MsgSendPacket memory msgSendPacket = IICS26RouterMsgs.MsgSendPacket({
+            sourceChannel: msg_.sourceChannel,
            timeoutTimestamp: msg_.timeoutTimestamp, // TODO: Default timestamp?


We should impose some limits on this value

Created an issue for it #104

AdityaSripal · 2024-11-13T11:53:53Z

src/ICS26Router.sol

        string memory counterpartyId = ICS02_CLIENT.getCounterparty(msg_.sourceChannel).clientId;

        // TODO: validate all identifiers
        if (msg_.timeoutTimestamp <= block.timestamp) {
            revert IBCInvalidTimeoutTimestamp(msg_.timeoutTimestamp, block.timestamp);
        }

-        uint32 sequence = IBC_STORE.nextSequenceSend(msg_.sourcePort, msg_.sourceChannel);
+        uint32 sequence = IBC_STORE.nextSequenceSend(payload.sourcePort, msg_.sourceChannel);


This should only be keyed on the source Channel now.

Adding this fix to: #101

AdityaSripal · 2024-11-13T11:55:40Z

src/ICS26Router.sol

+            revert IBCMultiPayloadPacketNotSupported();
+        }
+        Payload calldata payload = msg_.packet.payloads[0];
+
        IICS02ClientMsgs.CounterpartyInfo memory cInfo = ICS02_CLIENT.getCounterparty(msg_.packet.destChannel);
        if (keccak256(bytes(cInfo.clientId)) != keccak256(bytes(msg_.packet.sourceChannel))) {


This seems wrong

Getting fixed in your PR, it seems: #100

AdityaSripal · 2024-11-13T12:58:21Z

src/utils/ICS24Host.sol

-        return abi.encodePacked(
-            "commitments/ports/", portId, "/channels/", channelId, "/sequences/", Strings.toString(sequence)
-        );
+        return abi.encodePacked("commitments/channels/", channelId, "/sequences/", Strings.toString(sequence));


These paths need to be changed

Getting fixed in: #101

gjermundgaraba added 9 commits November 5, 2024 11:47

deploy with latest ibc-go eureka

d39cbfb

change package structure

56e939a

builds (but test fails)

c6a513f

update light clients with merkle_path

d261c74

Merge branch 'main' into gjermund/78-update-simapp-used-to-latest-ver…

54f7e3b

…sion-of-ibc-go-with-eureka

first transfer test working e2e

9bfcde9

second test passing

1c7f52e

timout tests work

ad24446

update and fix fixtures

310f512

gjermundgaraba linked an issue Nov 11, 2024 that may be closed by this pull request

Update simapp used to latest version of ibc-go with Eureka #78

Closed

lint and cleanup

cd26807

gjermundgaraba commented Nov 11, 2024

View reviewed changes

minor cleanup

5f9a874

gjermundgaraba marked this pull request as ready for review November 11, 2024 11:50

gjermundgaraba requested a review from srdtrk as a code owner November 11, 2024 11:50

gjermundgaraba requested a review from AdityaSripal November 11, 2024 11:51

gjermundgaraba added 2 commits November 11, 2024 15:30

use correct paths for proofs

3c14e5c

lint

22857b3

srdtrk reviewed Nov 12, 2024

View reviewed changes

gjermundgaraba and others added 6 commits November 12, 2024 10:32

Update src/ICS20Transfer.sol

edc30d4

Co-authored-by: srdtrk <[email protected]>

Update src/ICS20Transfer.sol

2372039

Co-authored-by: srdtrk <[email protected]>

Update src/utils/ICS24Host.sol

2735e70

Co-authored-by: srdtrk <[email protected]>

Update src/utils/ICS24Host.sol

1b8a67d

Co-authored-by: srdtrk <[email protected]>

Merge branch 'main' into gjermund/78-update-simapp-used-to-latest-ver…

316196f

…sion-of-ibc-go-with-eureka

code review cleanup

311bea2

gjermundgaraba requested a review from srdtrk November 12, 2024 10:17

gjermundgaraba added 2 commits November 12, 2024 12:22

take in list of acks

db87834

Merge branch 'main' into gjermund/78-update-simapp-used-to-latest-ver…

f20fd59

…sion-of-ibc-go-with-eureka

update fixtures and all that jazz

6c5d9c7

srdtrk approved these changes Nov 13, 2024

View reviewed changes

srdtrk added 6 commits November 13, 2024 09:42

imp: removed unused fixtures

0000000

docs: added hashPayload natspec

0000000

imp: made hashPayload private

0000000

docs: updated benchmarks

0000000

docs: updated single packet benchmarks and formatted benchmarks

0000000

docs: updated sendTransfer

0000000

srdtrk merged commit f78f4e6 into main Nov 13, 2024
13 checks passed

srdtrk deleted the gjermund/78-update-simapp-used-to-latest-version-of-ibc-go-with-eureka branch November 13, 2024 03:09

AdityaSripal reviewed Nov 13, 2024

View reviewed changes

srdtrk mentioned this pull request Nov 14, 2024

Update packet commitment with the new Eureka specs #11

Closed

gjermundgaraba mentioned this pull request Nov 16, 2024

Set max timeout #104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update to latest ibc spec and use latest ibc-go eureka simapp in e2e #88

feat: update to latest ibc spec and use latest ibc-go eureka simapp in e2e #88

gjermundgaraba commented Nov 11, 2024

gjermundgaraba Nov 11, 2024

gjermundgaraba Nov 11, 2024

codecov bot commented Nov 11, 2024 •

edited

Loading

srdtrk left a comment

gjermundgaraba commented Nov 12, 2024

srdtrk left a comment

srdtrk Nov 13, 2024

srdtrk commented Nov 13, 2024

AdityaSripal Nov 12, 2024

gjermundgaraba Nov 16, 2024 •

edited

Loading

AdityaSripal Nov 13, 2024

gjermundgaraba Nov 16, 2024

AdityaSripal Nov 13, 2024

gjermundgaraba Nov 16, 2024 •

edited

Loading

AdityaSripal Nov 13, 2024

gjermundgaraba Nov 16, 2024

		/// @notice ICS20_ENCODING is the encoding string for ICS20 packet data.
		string public constant ICS20_ENCODING = "application/json";

feat: update to latest ibc spec and use latest ibc-go eureka simapp in e2e #88

feat: update to latest ibc spec and use latest ibc-go eureka simapp in e2e #88

Conversation

gjermundgaraba commented Nov 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 11, 2024 • edited Loading

Codecov Report

srdtrk left a comment

Choose a reason for hiding this comment

gjermundgaraba commented Nov 12, 2024

srdtrk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srdtrk commented Nov 13, 2024

Choose a reason for hiding this comment

gjermundgaraba Nov 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gjermundgaraba Nov 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 11, 2024 •

edited

Loading

gjermundgaraba Nov 16, 2024 •

edited

Loading

gjermundgaraba Nov 16, 2024 •

edited

Loading