-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use abi encoding of ICS20Transfer payload #117
Open
gjermundgaraba
wants to merge
26
commits into
main
Choose a base branch
from
gjermund/116-use-abi-encoding-in-ics20transfer-solidity-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c8b932f
start abi-encoding
sangier 0d643e0
fix transfer tests
sangier b6f5619
fix test, del json related code
sangier 36d0194
rm try catch
sangier 1f7c77a
lint
sangier 01ef938
Merge branch 'main' into stefano/95-abi-encoding
gjermundgaraba 13d95a1
rename PacketDataJSON
gjermundgaraba a61644d
lint
gjermundgaraba 569bb1c
fixtures and update benchmark
gjermundgaraba 3e2c74b
move generated types into abigen folder
gjermundgaraba 62d4be5
add comment on abi decoding
gjermundgaraba 1a0be5c
document abigen additions more
gjermundgaraba 9c5952c
remove unused ics20lib errors
gjermundgaraba 938fca4
Merge branch 'main' into gjermund/116-use-abi-encoding-in-ics20transf…
gjermundgaraba 69f2e14
add lint and test to abigen CI workflow
gjermundgaraba afc5fee
clean up abigen workflow
gjermundgaraba 3eaeb64
clean up more in abigen workflow
gjermundgaraba f917257
use yml instead of yaml
gjermundgaraba 5cebb4c
rename
gjermundgaraba df69446
fix syntax
gjermundgaraba 2f49530
fix syntax
gjermundgaraba 7a74b4d
generate abi
gjermundgaraba 1da63c9
Merge branch 'main' into gjermund/116-use-abi-encoding-in-ics20transf…
gjermundgaraba 07163f2
clean up ICS20TransferTest
gjermundgaraba 965faec
clean up more tests
gjermundgaraba 2977ae9
clean up IntegrationTest
gjermundgaraba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,9 @@ on: | |
| push: | ||
| branches: | ||
| - "main" | ||
| paths: | ||
| - "src/**" | ||
| - "test/**" | ||
|
|
||
| jobs: | ||
| lint: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,180 @@ | ||
| [ | ||
| { | ||
| "type": "function", | ||
| "name": "DEFAULT_PORT_ID", | ||
| "inputs": [], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "stateMutability": "view" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "FAILED_ACKNOWLEDGEMENT_JSON", | ||
| "inputs": [], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "bytes", | ||
| "internalType": "bytes" | ||
| } | ||
| ], | ||
| "stateMutability": "view" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "IBC_DENOM_PREFIX", | ||
| "inputs": [], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "stateMutability": "view" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "ICS20_ENCODING", | ||
| "inputs": [], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "stateMutability": "view" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "ICS20_VERSION", | ||
| "inputs": [], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "stateMutability": "view" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "SUCCESSFUL_ACKNOWLEDGEMENT_JSON", | ||
| "inputs": [], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "bytes", | ||
| "internalType": "bytes" | ||
| } | ||
| ], | ||
| "stateMutability": "view" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "decodePayload", | ||
| "inputs": [ | ||
| { | ||
| "name": "data", | ||
| "type": "bytes", | ||
| "internalType": "bytes" | ||
| } | ||
| ], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "tuple", | ||
| "internalType": "struct ICS20Lib.FungibleTokenPacketData", | ||
| "components": [ | ||
| { | ||
| "name": "denom", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| }, | ||
| { | ||
| "name": "sender", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| }, | ||
| { | ||
| "name": "receiver", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| }, | ||
| { | ||
| "name": "amount", | ||
| "type": "uint256", | ||
| "internalType": "uint256" | ||
| }, | ||
| { | ||
| "name": "memo", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "stateMutability": "pure" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "toHexHash", | ||
| "inputs": [ | ||
| { | ||
| "name": "str", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "stateMutability": "pure" | ||
| }, | ||
| { | ||
| "type": "function", | ||
| "name": "toIBCDenom", | ||
| "inputs": [ | ||
| { | ||
| "name": "fullDenomPath", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "outputs": [ | ||
| { | ||
| "name": "", | ||
| "type": "string", | ||
| "internalType": "string" | ||
| } | ||
| ], | ||
| "stateMutability": "pure" | ||
| }, | ||
| { | ||
| "type": "error", | ||
| "name": "StringsInsufficientHexLength", | ||
| "inputs": [ | ||
| { | ||
| "name": "value", | ||
| "type": "uint256", | ||
| "internalType": "uint256" | ||
| }, | ||
| { | ||
| "name": "length", | ||
| "type": "uint256", | ||
| "internalType": "uint256" | ||
| } | ||
| ] | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really related to this, so can take it out. I just figure it would be good limit runs of this when it's not necessary.