Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Added infraction tests to provider suite #2416

Merged
merged 11 commits into from
Dec 9, 2024
Merged

ci: Added infraction tests to provider suite #2416

merged 11 commits into from
Dec 9, 2024

Conversation

stana-miric
Copy link
Collaborator

@stana-miric stana-miric commented Nov 29, 2024 •
edited
Loading

This pr includessome interchain test changes:

  • Added tests for customizable infraction parameters that were implemented here.
  • Split provider suites with single and multiple validators
  • Enables running tests with custom image name and tag so that we can also run test on e.g. local built image. Added flags are PROVIDER_IMAGE_NAME and PROVIDER_IMAGE_TAG. Default values if we omit the flags are "ghcr.io/cosmos/interchain-security" and "latest".
    E.g. running cmd: make test-interchain PROVIDER_IMAGE_NAME=ics-local PROVIDER_IMAGE_TAG=v1

@stana-miric stana-miric self-assigned this Nov 29, 2024
@stana-miric stana-miric mentioned this pull request Nov 29, 2024
Merged
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Nov 29, 2024
@github-actions github-actions bot added the C:Build Assigned automatically by the PR labeler label Dec 6, 2024
@stana-miric stana-miric marked this pull request as ready for review December 6, 2024 16:21
@stana-miric stana-miric requested a review from a team as a code owner December 6, 2024 16:21
mpoke
mpoke approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/interchain/provider_single_val_test.go Outdated Show resolved Hide resolved
tests/interchain/provider_single_val_test.go Outdated Show resolved Hide resolved
tests/interchain/provider_single_val_test.go Outdated Show resolved Hide resolved
tests/interchain/provider_single_val_test.go Outdated
@@ -658,3 +618,127 @@ func (s *ProviderSuite) TestProviderOwnerChecks() {
s.Require().Equal(powerShapingParams.Top_N, uint32(consumerChain.PowerShapingParams.TopN))
s.Require().Equal(chainsuite.GovModuleAddress, consumerChain.OwnerAddress)
}

// Tests adding and updating infraction parameters with MsgCreateConsumer, MsgUpdateConsumer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the scenarios tested in the docstring.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 3a2f0e2

@mpoke mpoke merged commit c715a97 into main Dec 9, 2024
17 checks passed
@mpoke mpoke deleted the smiric/infraction-interchain-test branch December 9, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@mpoke mpoke mpoke approved these changes

Assignees

@stana-miric stana-miric

Labels
C:Build Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stana-miric @mpoke @MSalopek