Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: enable chains to allowlist reward denoms permissionlessly #2309

Merged
merged 8 commits into from
Oct 2, 2024
Merged

feat!: enable chains to allowlist reward denoms permissionlessly #2309

merged 8 commits into from
Oct 2, 2024

Conversation

insumity
Copy link
Contributor

@insumity insumity commented Sep 23, 2024 •
edited
Loading

Description

Closes: #2298

Note that this PR stores the ConsumerRewardsAllocation per denom, although we could only store the amount. This was done to simplify the changes needed to make this work (under the current time constraints). We can revisit later on.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Sep 23, 2024
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Sep 25, 2024
@insumity insumity force-pushed the insumity/introduce-per-consumer-reward-denom-allowlisting branch 3 times, most recently from 5738abe to 12dccf3 Compare September 26, 2024 08:40
@insumity insumity force-pushed the insumity/introduce-per-consumer-reward-denom-allowlisting branch from 12dccf3 to b4489d8 Compare September 26, 2024 08:50
@insumity insumity marked this pull request as ready for review September 26, 2024 09:08
@insumity insumity requested a review from a team as a code owner September 26, 2024 09:08
insumity
insumity commented Sep 26, 2024
View reviewed changes
tests/integration/distribution.go
s.providerChain.NextBlock()
}

// Allowlist the consumer reward denom. This would be done by a governance proposal in prod.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this test passes if we were to remove the following line and do:
providerKeeper.SetAllowlistedRewardDenom(s.providerCtx(), s.getFirstBundle().ConsumerId, rewardsIBCdenom) instead.

@insumity insumity mentioned this pull request Sep 27, 2024
Open
@insumity insumity force-pushed the insumity/introduce-per-consumer-reward-denom-allowlisting branch from 9e9511d to 06ea1f7 Compare September 27, 2024 14:25
@insumity insumity mentioned this pull request Sep 27, 2024
Merged
18 tasks
@insumity insumity changed the title feat!: allow chains to whitelist reward denoms permissionlessly feat!: enable chains to allowlist reward denoms permissionlessly Sep 27, 2024
MSalopek
MSalopek approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sainoe
sainoe approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@sainoe sainoe added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 33ea185 Oct 2, 2024
16 of 17 checks passed
@sainoe sainoe deleted the insumity/introduce-per-consumer-reward-denom-allowlisting branch October 2, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@sainoe sainoe sainoe approved these changes

Assignees
No one assigned
Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow permissionless denom allowlisting
3 participants
@insumity @sainoe @MSalopek