Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade PSS to SDK v0.50.x (ICS v4.3.x features only) #1996

Merged
merged 62 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
b7d4f53
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.26.0 …
dependabot[bot] Apr 23, 2024
6f70509
chore: add v4.1.x to docs and cleanup bots (#1812)
mpoke Apr 23, 2024
7bd9fa1
build(deps): bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to…
dependabot[bot] Apr 29, 2024
f5f626c
docs: add docs versioning and legacy page (pre v4.0.0) (#1833)
MSalopek Apr 30, 2024
4550c33
build(deps): bump JamesIves/github-pages-deploy-action from 4.5.0 to …
dependabot[bot] Apr 30, 2024
e5bd937
chore: add release/v5.x bots targets (#1829)
MSalopek Apr 30, 2024
08c0376
chore: fix spelling errors (#1835)
github-prbot Apr 30, 2024
d282e07
build(deps): bump github.com/hashicorp/go-getter from 1.7.1 to 1.7.4 …
dependabot[bot] Apr 30, 2024
4975d6b
docs: update docs deployment (#1841)
MSalopek Apr 30, 2024
2ace39c
build(deps): bump amannn/action-semantic-pull-request from 5.4.0 to 5…
dependabot[bot] May 1, 2024
ab71eae
build(deps): bump bufbuild/buf-setup-action from 1.30.1 to 1.31.0 (#1…
dependabot[bot] May 1, 2024
8c4d87f
feat!: Introduce Partial Set Security (#1809)
p-offtermatt May 1, 2024
d313ba5
chore: add v5.0.x-provider and v5.0.x-provider to mergify and dependa…
insumity May 1, 2024
2b5b6cf
fix: revert version bump to v5 (#1847)
sainoe May 2, 2024
ad6ecbb
chore: rm v5-provider; add v4.2.0; rm old versions (#1849)
MSalopek May 2, 2024
fab1224
chore: Add coderabbit configuration file (#1852)
p-offtermatt May 2, 2024
28d6982
refactor: remove redundant code from MakeConsumerGenesis (#1807)
mpoke May 2, 2024
5bb6b1c
refactor: nit naming changes (#1854)
insumity May 2, 2024
4f33a3e
docs: ADR for Security Aggregation solution (#1866)
bermuell May 8, 2024
3328e9b
chore: Make coderabbit ignore docs folder (#1864)
p-offtermatt May 8, 2024
8329a27
chore: Fix codespell config (#1869)
p-offtermatt May 10, 2024
78dad0c
feat: PSS - Add minimum power in top N & power shaping params to cons…
p-offtermatt May 13, 2024
e3b6490
chore: fixed all-pairs-valconsensus-address CLI command usage (#1870)
freak12techno May 13, 2024
c05de0e
chore: Try to make coderabbit ignore missing/extra newlines in md fil…
p-offtermatt May 14, 2024
1294f90
docs: Add PSS docs (#1859)
p-offtermatt May 14, 2024
0b24c30
docs: Minor improvements (#1882)
p-offtermatt May 16, 2024
04afa78
build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#…
dependabot[bot] May 16, 2024
e1b191a
feat: add a query to retrieve validator set that was last sent to the…
insumity May 17, 2024
a0645d8
fix!: drop chain proposals with empty validator set at spawn time (#1…
insumity May 17, 2024
26d6800
test: Remove v5.0.0 (pre-release) be tested within e2e compatibility …
bermuell May 17, 2024
a1557bb
test: add E2E test for power-shaping features (#1853)
insumity May 17, 2024
36a2876
build(deps): bump comet to v0.37.6 (#1876)
mpoke May 17, 2024
a4ffa1a
docs: add v4.2.0; bump v5.0.0 (#1900)
MSalopek May 17, 2024
5f864a5
docs: fix broken docs deploy (v4.2.0) (#1903)
MSalopek May 17, 2024
adab6df
chore: fix spelling errors (#1904)
github-prbot May 22, 2024
f879208
build(deps): bump JamesIves/github-pages-deploy-action from 4.6.0 to …
dependabot[bot] May 22, 2024
7fba468
build(deps): bump bufbuild/buf-setup-action from 1.31.0 to 1.32.0 (#1…
dependabot[bot] May 22, 2024
369554c
build(deps): bump google.golang.org/grpc from 1.63.2 to 1.64.0 (#1908)
dependabot[bot] May 22, 2024
417c899
docs: document democracy modules in more detail (#1915)
MSalopek May 24, 2024
a4c7a82
docs: bring v4.2.0 changelog to main (#1909)
mpoke May 24, 2024
2960c5b
build(deps): bump github.com/cosmos/ibc-go/v7 from 7.4.0 to 7.5.0 (#1…
dependabot[bot] May 24, 2024
16ee6a2
chore: fix spelling errors (#1922)
github-prbot May 27, 2024
3132f64
fix(client): write unbonding period advisory to stderr instead of std…
chris-ricketts May 27, 2024
98bd90f
docs: update ADR metadata (#1910)
mpoke May 27, 2024
78f9b1e
Merge branch 'main' into sainoe/pss-upgrade
sainoe May 30, 2024
c48fcd8
fix: migration and error code duplication + e2e tests (#1930)
bermuell May 31, 2024
35f6bf5
test: e2e fix PSS tests (#1931)
bermuell Jun 5, 2024
a8a5ca2
chore!: fix PSS mem-tests (SDK v50 upgrade) (#1933)
sainoe Jun 5, 2024
f346a85
chore!: Add last PSS changes (#1941)
sainoe Jun 10, 2024
330cfdb
chore!: backport #1946 (GetAllConsumerChains fix) to `feat/pss-upgrad…
sainoe Jun 12, 2024
1670012
fix: backport #1949 + fix handler entry (#1960)
bermuell Jun 13, 2024
402c854
chore: backport regression mem tests for Hub halt (#1945) (#1965)
sainoe Jun 14, 2024
57938b7
test: backport #1942 (#1963)
bermuell Jun 17, 2024
134de6a
chore: use `IterateLastValidatorPowers` instead of `GetLastValidators…
sainoe Jun 19, 2024
193f15f
feat!: store the minimal power to be in the top N on EndBlock (#1977)
bermuell Jun 21, 2024
7676773
chore: align to LSM hook signature to SDK v0.50.0 (#1984)
sainoe Jun 24, 2024
3e63d54
fix!: update PSS reward distribution to work with SDK v0.50.0 changes…
sainoe Jun 25, 2024
2f01f9c
chore!: only distribute rewards to validators that have been validati…
sainoe Jun 25, 2024
c51d16a
Update proto/interchain_security/ccv/provider/v1/tx.proto
sainoe Jun 28, 2024
0a2f411
address coments
sainoe Jun 28, 2024
74b637a
--amend
sainoe Jun 28, 2024
85aabd0
nits
sainoe Jun 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/1921-write-stderr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Write unbonding period advisory to stderr instead of stdout
([\#1921](https://github.com/cosmos/interchain-security/pull/1921))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Apply audit suggestions that include a bug fix in the way we compute the
maximum capped power. ([\#1925](https://github.com/cosmos/interchain-
security/pull/1925))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Replace `GetAllConsumerChains` with lightweight version
(`GetAllRegisteredConsumerChainIDs`) that doesn't call into the staking module
([\#1946](https://github.com/cosmos/interchain-security/pull/1946))
3 changes: 3 additions & 0 deletions .changelog/unreleased/dependencies/1924-bump-ibc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Bump [ibc-go](https://github.com/cosmos/ibc-go) to
[v7.5.1](https://github.com/cosmos/ibc-go/releases/tag/v7.5.1).
([\#1924](https://github.com/cosmos/interchain-security/pull/1924))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Only start distributing rewards to validators after they have been validating
for a fixed number of blocks. Introduces the `NumberOfEpochsToStartReceivingRewards` param.
([\#1929](https://github.com/cosmos/interchain-security/pull/1929))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Apply audit suggestions that include a bug fix in the way we compute the
maximum capped power. ([\#1925](https://github.com/cosmos/interchain-
security/pull/1925))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Only start distributing rewards to validators after they have been validating
for a fixed number of blocks. Introduces the `NumberOfEpochsToStartReceivingRewards` param.
([\#1929](https://github.com/cosmos/interchain-security/pull/1929))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Assigning a key that is already assigned by the same validator will now be a no-op instead of throwing an error.
([\#1732](https://github.com/cosmos/interchain-security/pull/1732))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Changes the `list-consumer-chains` query to include a `min_power_in_top_N` field, as well as fields for all power shaping parameters of the consumer.
([\#1863](https://github.com/cosmos/interchain-security/pull/1863))
3 changes: 3 additions & 0 deletions .changelog/v4.2.0/dependencies/1876-bump-comet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Bump [CometBFT](https://github.com/cometbft/cometbft) to
[v0.37.6](https://github.com/cometbft/cometbft/releases/tag/v0.37.6).
([\#1876](https://github.com/cosmos/interchain-security/pull/1876))
3 changes: 3 additions & 0 deletions .changelog/v4.2.0/dependencies/1876-bump-sdk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to
[v0.47.11](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.11).
([\#1876](https://github.com/cosmos/interchain-security/pull/1876))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Enable Opt In and Top N chains through gov proposals.
([\#1587](https://github.com/cosmos/interchain-security/pull/1587))
3 changes: 3 additions & 0 deletions .changelog/v4.2.0/features/provider/1809-pss.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Adding the Partial Set Security (PSS) feature cf. [ADR 015](https://cosmos.github.io/interchain-security/adrs/adr-015-partial-set-security).
PSS enables consumer chains to join ICS as _Top N_ or _Opt In_ chains and enables validators to opt to validate the consumer chains they want.
([\#1809](https://github.com/cosmos/interchain-security/pull/1809))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Introduce power-shaping features for consumer chains. The features: (i) allow us to cap the total number of validators that can validate the consumer chain, (ii) set a cap on the maximum voting power (percentage-wise) a validator can have on a consumer chain, and (iii) introduce allowlist and denylists to restrict which validators are allowed or not to validate a consumer chain.
([\#1830](https://github.com/cosmos/interchain-security/pull/1830))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Changes the `list-consumer-chains` query to include a `min_power_in_top_N` field, as well as fields for all power shaping parameters of the consumer.
([\#1863](https://github.com/cosmos/interchain-security/pull/1863))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Introduces the `consumer-validators` query to retrieve the latest set consumer-validator set for a consumer chain.
([\#1863](https://github.com/cosmos/interchain-security/pull/1867))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Enable Opt In and Top N chains through gov proposals.
([\#1587](https://github.com/cosmos/interchain-security/pull/1587))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Assigning a key that is already assigned by the same validator will now be a no-op instead of throwing an error.
([\#1732](https://github.com/cosmos/interchain-security/pull/1732))
2 changes: 2 additions & 0 deletions .changelog/v4.2.0/state-breaking/provider/1809-pss.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Adding the Partial Set Security feature cf. [ADR 015](https://cosmos.github.io/interchain-security/adrs/adr-015-partial-set-security).
([\#1809](https://github.com/cosmos/interchain-security/pull/1809))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Introduce power-shaping features for consumer chains. The features: (i) allow us to cap the total number of validators that can validate the consumer chain, (ii) set a cap on the maximum voting power (percentage-wise) a validator can have on a consumer chain, and (iii) introduce allowlist and denylists to restrict which validators are allowed or not to validate a consumer chain.
([\#1830](https://github.com/cosmos/interchain-security/pull/1830))
1 change: 1 addition & 0 deletions .changelog/v4.2.0/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
May 17, 2024
41 changes: 41 additions & 0 deletions .coderabbit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
language: "en"
early_access: false
reviews:
request_changes_workflow: false
high_level_summary: true
poem: false
review_status: false
collapse_walkthrough: true
path_filters:
- "!api/"
- "!docs/"
path_instructions:
- path: "**/*.go"
instructions: "Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations."
- path: "tests/e2e/*"
instructions: |
"Assess the e2e test code assessing sufficient code coverage for the changes associated in the pull request"
- path: "tests/integration/*"
instructions: |
"Assess the e2e test code assessing sufficient code coverage for the changes associated in the pull request"
- path: "**/*_test.go"
instructions: |
"Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
- path: "**/*.md"
instructions: |
"Assess the documentation for misspellings, grammatical errors, missing documentation and correctness. Please DO NOT report any missing or superfluous newlines, in particular at the end or beginning of files."
- path: ".changelog/*"
instructions: |
"Assess the changes in the changelog for correctness and completeness, particularly flagging missing changes"
auto_review:
enabled: true
ignore_title_keywords:
- "WIP"
- "DO NOT MERGE"
drafts: false
base_branches:
- "main"
- "feat/*"
- "release/*"
chat:
auto_reply: true
2 changes: 2 additions & 0 deletions .github/.codespellignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
clienta
connectiona
sover
optin
opt-in
39 changes: 5 additions & 34 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ updates:
directory: "/"
schedule:
interval: daily
target-branch: "release/v2.0.x"
target-branch: "release/v4.1.x"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
Expand All @@ -32,27 +32,7 @@ updates:
directory: "/"
schedule:
interval: daily
target-branch: "release/v2.4.x-lsm"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
- dependencies

- package-ecosystem: gomod
directory: "/"
schedule:
interval: daily
target-branch: "release/v3.1.x"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
- dependencies

- package-ecosystem: gomod
directory: "/"
schedule:
interval: daily
target-branch: "release/v3.2.x"
target-branch: "release/v4.1.x-lsm"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
Expand All @@ -62,7 +42,7 @@ updates:
directory: "/"
schedule:
interval: daily
target-branch: "release/v3.3.x"
target-branch: "release/v4.2.x"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
Expand All @@ -72,7 +52,7 @@ updates:
directory: "/"
schedule:
interval: daily
target-branch: "release/v4.0.x"
target-branch: "release/v4.2.x-lsm"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
Expand All @@ -82,18 +62,9 @@ updates:
directory: "/"
schedule:
interval: daily
target-branch: "release/v4.1.x"
target-branch: "release/v5.x"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
- dependencies

- package-ecosystem: gomod
directory: "/"
schedule:
interval: daily
target-branch: "release/v4.1.x-lsm"
# Only allow automated security-related dependency updates on release branches.
open-pull-requests-limit: 0
labels:
- dependencies
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.21"
go-version: "1.22"
check-latest: true
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@ jobs:
- name: Build 🔧
run: |
npm install -g [email protected]
make build-docs
cd docs
./sync_versions.sh
./build_deploy.sh

- name: Deploy 🚀
uses: JamesIves/github-pages-deploy-action@v4.5.0
uses: JamesIves/github-pages-deploy-action@v4.6.1
with:
branch: gh-pages
folder: ~/output
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
# https://github.com/docker/login-action
- name: Log into registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20 # v3.1.0
uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.21'
go-version: '1.22'
- uses: technote-space/[email protected]
id: git_diff
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
statuses: write # for amannn/action-semantic-pull-request to mark status of analyzed PR
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v5.4.0
- uses: amannn/action-semantic-pull-request@v5.5.2
id: lint_pr_title
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
Loading
Loading