-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken link on docs page #1991
Conversation
WalkthroughWalkthroughThe main change entails updating the link to the Architectural Decision Record (ADR) template in the Changes
Recent review detailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Additional context usedPath-based instructions (1)
LanguageTool
Markdownlint
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
docs/docs/adrs/intro.md (1)
Line range hint
6-6
: Consider restructuring to avoid multiple top-level headings.Using multiple top-level headings (
#
) can be confusing and does not follow best practices for Markdown file structure. Consider using secondary headings (##
) for major sections after the first.- # Overview + ## OverviewTools
LanguageTool
[uncategorized] ~26-~26: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...re, and then modify the code to match. Note the context/background should be writte...
@@ -26,7 +26,7 @@ If recorded decisions turned out to be lacking, convene a discussion, record the | |||
|
|||
Note the context/background should be written in the present tense. | |||
|
|||
To suggest an ADR, please make use of the [ADR template](./templates/adr-template.md) provided. | |||
To suggest an ADR, please make use of the [ADR template](https://github.com/cosmos/interchain-security/blob/main/docs/docs/adrs/templates/adr-template.md) provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 This link does not seem broken when going [https://github.com/cosmos/interchain-security/blob/main/docs/docs/adrs/intro.md] here by clicking on it. Not sure if I'm missing something but we seem to use the ./dir1/...
extensively in our docs with no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template is not render on the docs site. That's why it needs to be a github link.
fix broken link on docs page
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:
prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:
prefix in the PR titlemake build-docs
)Summary by CodeRabbit
intro.md
to point to a new location on GitHub.