Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #1973

Merged
merged 5 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Additionally, **each PR should only address a single issue**.

### Pull Request Templates

There are three PR templates. The [default template](./.github/PULL_REQUEST_TEMPLATE.md) contains links to the three templates. Please go the the `Preview` tab and select the appropriate sub-template:
There are three PR templates. The [default template](./.github/PULL_REQUEST_TEMPLATE.md) contains links to the three templates. Please go the `Preview` tab and select the appropriate sub-template:
omahs marked this conversation as resolved.
Show resolved Hide resolved

- The [production template](./.github/PULL_REQUEST_TEMPLATE/production.md) is for types `fix`, `feat`, and `refactor`.
- The [docs template](./.github/PULL_REQUEST_TEMPLATE/docs.md) is for documentation changes.
Expand Down
4 changes: 2 additions & 2 deletions RELEASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ This includes events, queries, CLI interfaces.
## Release Cycle

ICS follows a traditional release cycle involving release candidates (RCs) releases before finalizing a new version.
The stable release guarantees do not go into affect until a final release is performed.
The stable release guarantees do not go into effect until a final release is performed.

❗***It is never advisable to use a non-final release in production.***

Expand Down Expand Up @@ -95,4 +95,4 @@ The following table indicates the compatibility of currently active releases:
| `v3.2.0` || ✅ |
| `v4.0.0` || ✅ |
| `v4.2.0` || ✅ |
| `v5.0.0` || ✅ |
| `v5.0.0` || ✅ |
6 changes: 3 additions & 3 deletions RELEASE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This document outlines the release process for Interchain Security (ICS).

For details on ICS releases, see [RELEASES.md](./RELEASES.md).

The procedure of cutting a major or minor release consist of the following steps:
The procedure of cutting a major or minor release consists of the following steps:

- Create a new version section in the `CHANGELOG.md` (follow the procedure described [below](#changelog))
- Create release notes, in `RELEASE_NOTES.md`, highlighting the new features and changes in the version.
Expand Down Expand Up @@ -71,7 +71,7 @@ Before cutting a _**release candidate**_ (e.g., `v3.3.0-rc0`), the following ste
unclog release v3.3.0
```
- `unclog release` requires an editor. This can be set either by configuring
an `$EDITOR` environment variable or by manually specify an editor binary path
an `$EDITOR` environment variable or by manually specifying an editor binary path
via the `--editor` flag.
- add the date as the summary of the release (`unclog release` requires adding a summary), e.g.,
```md
Expand Down Expand Up @@ -136,4 +136,4 @@ git push origin v3.2.0
```

For final releases, once the tag is created, use the GitHub interface to create a release.
Note that this is not necessary for release candidates.
Note that this is not necessary for release candidates.
4 changes: 2 additions & 2 deletions UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Upgrading the provider from `v2.x.y` to `v3.3.0` will not require state migratio

## [v3.2.x](https://github.com/cosmos/interchain-security/tree/release/v3.2.x)

`v3.2.0` bumps IBC to `v7.3`. As a result, `legacy_ibc_testing` is not longer required and was removed, see https://github.com/cosmos/interchain-security/pull/1185. This means that when upgrading to `v3.2.0`, any customized tests relying on `legacy_ibc_testing` need to be updated.
`v3.2.0` bumps IBC to `v7.3`. As a result, `legacy_ibc_testing` is no longer required and was removed, see https://github.com/cosmos/interchain-security/pull/1185. This means that when upgrading to `v3.2.0`, any customized tests relying on `legacy_ibc_testing` need to be updated.

### Consumer

Expand Down Expand Up @@ -124,7 +124,7 @@ Legacy APIs of the `AppModule` interface have been removed from ccv modules. For

#### Imports

Imports for ics23 have been updated as the repository have been migrated from confio to cosmos.
Imports for ics23 have been updated as the repository has been migrated from confio to cosmos.

```diff
import (
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,7 @@ func (tc TestConfig) getTrustedHeight(

var trustedHeight gjson.Result
// iterate on the relayer's response
// and parse the the command "result"
// and parse the command "result"
for scanner.Scan() {
out := scanner.Text()
if len(gjson.Get(out, "result").Array()) > 0 {
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/unbonding.go
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ func (s *CCVTestSuite) TestTooManyLastValidators() {
lastVals := pk.GetLastBondedValidators(s.providerCtx())

// pass one block to apply the validator set changes
// (calls ApplyAndReturnValidatorSetUpdates in the the staking module EndBlock)
// (calls ApplyAndReturnValidatorSetUpdates in the staking module EndBlock)
s.providerChain.NextBlock()

// verify that the number of bonded validators is decreased by one
Expand Down
2 changes: 1 addition & 1 deletion tests/mbt/model/ccv.qnt
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ module ccv {
}

// Delivers the next queued VscMaturedPacket from a consumer chain to the provider chain.
// Arguments are the currentState and the the consumer chain, from which the packet will be delivered.
// Arguments are the currentState and the consumer chain, from which the packet will be delivered.
// If this packet will time out on the provider on delivery,
// the consumer will be dropped.
// The first return is the result of the operation, the second result is a boolean
Expand Down
2 changes: 1 addition & 1 deletion x/ccv/consumer/keeper/validators.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (k Keeper) Slash(ctx sdk.Context, addr sdk.ConsAddress, infractionHeight, p
return k.SlashWithInfractionReason(ctx, addr, infractionHeight, power, slashFactor, stakingtypes.Infraction_INFRACTION_UNSPECIFIED)
}

// Slash queues a slashing request for the the provider chain
// Slash queues a slashing request for the provider chain
// All queued slashing requests will be cleared in EndBlock
// Called by Slashing keeper in SlashWithInfractionReason
func (k Keeper) SlashWithInfractionReason(ctx sdk.Context, addr sdk.ConsAddress, infractionHeight, power int64, slashFactor sdk.Dec, infraction stakingtypes.Infraction) math.Int {
Expand Down
2 changes: 1 addition & 1 deletion x/ccv/provider/ibc_middleware.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func (im IBCMiddleware) GetAppVersion(ctx sdk.Context, portID, channelID string)
// It follows the same logic than the OnRecvPacket method of the IBC transfer module
// see https://github.com/cosmos/ibc-go/blob/v7.3.2/modules/apps/transfer/keeper/relay.go#L162
func GetProviderDenom(denom string, packet channeltypes.Packet) (providerDenom string) {
// If the the prefix denom corresponds to the packet's source port and channel,
// If the prefix denom corresponds to the packet's source port and channel,
// returns the base denom
if ibctransfertypes.ReceiverChainIsSource(packet.GetSourcePort(), packet.GetSourceChannel(), denom) {
voucherPrefix := ibctransfertypes.GetDenomPrefix(packet.GetSourcePort(), packet.GetSourceChannel())
Expand Down
6 changes: 3 additions & 3 deletions x/ccv/provider/keeper/consumer_equivocation.go
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ func (k Keeper) SlashValidator(ctx sdk.Context, providerAddr types.ProviderConsA
// CRUD section
//

// SetEquivocationEvidenceMinHeight sets the the minimum height
// SetEquivocationEvidenceMinHeight sets the minimum height
// of a valid consumer equivocation evidence for a given consumer chain ID
func (k Keeper) SetEquivocationEvidenceMinHeight(ctx sdk.Context, chainID string, height uint64) {
store := ctx.KVStore(k.storeKey)
Expand All @@ -460,7 +460,7 @@ func (k Keeper) SetEquivocationEvidenceMinHeight(ctx sdk.Context, chainID string
store.Set(types.EquivocationEvidenceMinHeightKey(chainID), heightBytes)
}

// GetEquivocationEvidenceMinHeight returns the the minimum height
// GetEquivocationEvidenceMinHeight returns the minimum height
// of a valid consumer equivocation evidence for a given consumer chain ID
func (k Keeper) GetEquivocationEvidenceMinHeight(ctx sdk.Context, chainID string) uint64 {
store := ctx.KVStore(k.storeKey)
Expand All @@ -472,7 +472,7 @@ func (k Keeper) GetEquivocationEvidenceMinHeight(ctx sdk.Context, chainID string
return binary.BigEndian.Uint64(bz)
}

// DeleteEquivocationEvidenceMinHeight deletes the the minimum height
// DeleteEquivocationEvidenceMinHeight deletes the minimum height
// of a valid consumer equivocation evidence for a given consumer chain ID
func (k Keeper) DeleteEquivocationEvidenceMinHeight(ctx sdk.Context, chainID string) {
store := ctx.KVStore(k.storeKey)
Expand Down
Loading