chore: fix spelling errors #1871
Conversation
WalkthroughWalkthroughThe recent updates primarily involve renaming the Changes
This table groups files with similar changes, focusing on renaming and typo corrections, providing a clear and concise overview of the modifications. Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (9)
Files skipped from review due to trivial changes (3)
Additional Context UsedGitHub Check Runs (3)
Path-based Instructions (3)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
C:Testing
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -27,7 +27,7 @@ func NewHandler(k *keeper.Keeper) sdk.Handler { | |||
| res, err := msgServer.SubmitConsumerDoubleVoting(sdk.WrapSDKContext(ctx), msg) | |||
| return sdk.WrapServiceResult(ctx, res, err) | |||
| case *types.MsgOptIn: | |||
| res, err := msgServer.OptIn(sdk.WrapSDKContext(ctx), msg) | |||
| res, err := msgServer.option(sdk.WrapSDKContext(ctx), msg) | |||
There was a problem hiding this comment.
Consider renaming option to a more descriptive name to avoid confusion with common programming keywords.
| @@ -83,7 +83,7 @@ module ccv_pss_model { | |||
|
|
|||
| val CanOptIn = { | |||
| not( | |||
| trace[length(trace)-1].kind == "OptIn" | |||
| trace[length(trace)-1].kind == "option" | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The verification process has revealed that the trace kind option is used only once in the file tests/mbt/model/ccv_pss_model.qnt. This suggests that the usage of this trace kind is not consistent across all relevant parts of the model, which could impact traceability and debugging clarity as noted in the review comment.
- Location of the inconsistency:
tests/mbt/model/ccv_pss_model.qnt
Analysis chain
Ensure that the trace kind option is consistently used across all relevant parts of the model to maintain traceability and debugging clarity.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify consistent use of the trace kind `option` in the model.
# Test: Search for the trace kind usage. Expect: Only occurrences of the trace kind `option`.
rg --type qnt $'trace.*kind == "option"'
Length of output: 69
Script:
#!/bin/bash
# Description: Re-verify consistent use of the trace kind `option` in the model by searching all files.
# Test: Search for the trace kind usage in all files. Expect: Only occurrences of the trace kind `option`.
rg 'trace.*kind == "option"'
Length of output: 116
| rpc AssignConsumerKey(MsgAssignConsumerKey) returns (MsgAssignConsumerKeyResponse); | ||
| rpc SubmitConsumerMisbehaviour(MsgSubmitConsumerMisbehaviour) returns (MsgSubmitConsumerMisbehaviourResponse); | ||
| rpc SubmitConsumerDoubleVoting(MsgSubmitConsumerDoubleVoting) returns (MsgSubmitConsumerDoubleVotingResponse); | ||
| rpc OptIn(MsgOptIn) returns (MsgOptInResponse); | ||
| rpc option(MsgOptIn) returns (MsgOptInResponse); |
There was a problem hiding this comment.
Consider renaming the RPC method option to something more descriptive to avoid confusion with common programming keywords and potential issues in code generation.
| @@ -137,7 +137,7 @@ | |||
| return &types.MsgSubmitConsumerDoubleVotingResponse{}, nil | |||
| } | |||
|
|
|||
| func (k msgServer) OptIn(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | |||
| func (k msgServer) option(goCtx context.Context, msg *types.MsgOptIn) (*types.MsgOptInResponse, error) { | |||
There was a problem hiding this comment.
Consider renaming option to a more descriptive name to avoid confusion with common programming keywords.
|
How do i get this bot to stop renaming |
|
We have a PR, it is just missing an approval :D |
This PR fixes typos in the codebase.
Please review it, and merge if everything is fine.
If there are proto changes, run
make proto-genand commit the changes.Summary by CodeRabbit
Refactor
OptInfunction tooptionacross various modules for consistency.Bug Fixes