-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: introduce epochs #1660
Merged
Merged
feat!: introduce epochs #1660
Changes from 38 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
01daa3c
cleanup ./changelog entries
mpoke 1ab7c20
rebase
insumity efe8cb1
fix!: Validation of SlashAcks fails due to marshaling to Bech32 (bac…
mergify[bot] a5c1d4e
docs: update changelog for v4.0.0 (#1578)
mpoke c03587c
docs: prepare for v4.0.0 (#1581)
mpoke 6c39a2f
added proto declaration
insumity ddae681
temp commit
insumity c9b1b3e
temp commit
insumity e0861e2
more changes
insumity d6cd207
first commit
insumity d144c39
add param and fix tests
insumity 44d13cd
reduce epoch size for e2e
insumity 076ec8b
clean up
insumity a56b6e0
mbt fix
insumity 36afb40
fix diff bug
insumity 481fd88
cleaning up
insumity 35385dd
cleaning up
insumity 27290f6
cleaning up
insumity c707c54
cleaning up
insumity cf8bdb8
cleaning up
insumity ead0873
cleaning up
insumity 88081cd
added more tests
insumity f6397ad
more fixes
insumity bee8c10
nit fixes
insumity abb4abc
cleaning up
insumity 30f2061
increase downtime by one block
insumity e986692
fix logs
insumity 8aa1dc9
took into account Marius' comments
insumity 16958bc
tiny fixes
insumity 513a75d
Update x/ccv/provider/keeper/params.go
insumity 2208cd4
use Bech32 addresses as keys for maps
insumity 914840c
refactor nextBlocks(epoch) to nextEpoch
insumity 791e582
fixed comment
insumity 85a52b7
Remove new block creation during consumer chain setup
p-offtermatt f909e1a
Revert "Remove new block creation during consumer chain setup"
p-offtermatt d683b5a
added simple param test
insumity 44b9eb1
added upper bound and addressed a comment
insumity 538eee3
Add another edge case for diffing
p-offtermatt 294aacb
used smarted solution (based on Philip's comment) for diffing validators
insumity 31b7416
refactor!: remove key-assignment replacements (#1672)
insumity ba2ed34
add the epoch param in the docs
insumity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later calls to
waitBlocks
for 1 block have a timeout of 30 seconds, so for 3 blocks I'm adding a 90 seconds time out here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have to wait for 3 blocks when the epoch param is set to 2 blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Changed
blocks_per_epoch
to 3.