style: (tiny) rename variable to avoid shadowing #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/provider
mpoke
approved these changes
Feb 21, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
rename var to avoid shadowing (cherry picked from commit 6d09487)
mpoke
pushed a commit
that referenced
this pull request
Feb 21, 2024
) style: (tiny) rename variable to avoid shadowing (#1654) rename var to avoid shadowing (cherry picked from commit 6d09487) Co-authored-by: insumity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a tiny PR to avoid possible confusion when looking at the
QueueVSCPacketcode. We renamevalUpdatesreturned from the staking module tostakingValUpdatesso that thevalUpdatesvariable in theforloop does not shadow the outside variable. See 50 Shades of Go for more on this.Thanks to @MSalopek for pointing out the correctness of the original code!
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...