Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Validation of SlashAcks fails due to marshaling to Bech32 #1570

Merged
merged 28 commits into from
Jan 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a08ebba
add different Bech32Prefix for consumer and provider
mpoke Jan 16, 2024
cfaacdb
separate app encoding and params
mpoke Jan 16, 2024
0f2388c
remove ConsumerValPubKey from ValidatorConfig
mpoke Jan 16, 2024
fb721a1
update addresses in tests
mpoke Jan 16, 2024
f4e78c4
make SlashAcks consistent across chains
mpoke Jan 17, 2024
47d3a9c
add comments for clarity
mpoke Jan 17, 2024
f9b3bdf
Regenerate traces
p-offtermatt Jan 17, 2024
4027158
Fix argument order
p-offtermatt Jan 17, 2024
1ce3a93
set bech32prefix for provider to cosmos
mpoke Jan 17, 2024
07d4e30
fix merge conflict
mpoke Jan 17, 2024
22f4006
add changelog entries
mpoke Jan 17, 2024
413c43b
add consumer-double-downtime e2e test
mpoke Jan 17, 2024
47aac55
update nightly-e2e workflow
mpoke Jan 17, 2024
e78593d
fix typo
mpoke Jan 17, 2024
e5bd41d
add consumer-double-downtime to testConfigs
mpoke Jan 18, 2024
fb9b336
remove changes on provider
mpoke Jan 18, 2024
2094cf4
skip invalid SlashAcks
mpoke Jan 18, 2024
4979dfc
seal the config
mpoke Jan 18, 2024
905d666
clear the outstanding downtime flag for new vals
mpoke Jan 18, 2024
4626b78
add info on upgrading to v4.0.0
mpoke Jan 18, 2024
7b0cf50
fix upgrade handler
mpoke Jan 19, 2024
f0b9d7b
fix changeover e2e test
sainoe Jan 19, 2024
4c9588c
Update tests/e2e/config.go
mpoke Jan 19, 2024
1c00063
Update tests/e2e/config.go
mpoke Jan 19, 2024
7a8a5d5
add AccountPrefix to ChainConfig
mpoke Jan 19, 2024
db8feb1
fix docstrings
mpoke Jan 19, 2024
fc86224
update AccountAddressPrefix in app.go
mpoke Jan 19, 2024
03e740c
fix consumer-misb e2e test
sainoe Jan 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regenerate traces
p-offtermatt committed Jan 17, 2024
commit f9b3bdfdc607ade57abb622be92dc142f9e2a6c5
4 changes: 2 additions & 2 deletions tests/e2e/tracehandler_testdata/consumer-misbehaviour.json
Original file line number Diff line number Diff line change
@@ -107,10 +107,10 @@
"Rewards": null,
"ConsumerChains": null,
"AssignedKeys": {
"alice": "consumervalcons1muys5jyqk4xd27e208nym85kn0t4zjcfk9q5ce"
"alice": "providervalcons1muys5jyqk4xd27e208nym85kn0t4zjcfcryzvq"
},
"ProviderKeys": {
"alice": "consumervalcons1qmq08eruchr5sf5s3rwz7djpr5a25f7xpvpagq"
"alice": "providervalcons1qmq08eruchr5sf5s3rwz7djpr5a25f7x029tue"
},
"ConsumerPendingPacketQueueSize": null,
"RegisteredConsumerRewardDenoms": null,
4 changes: 2 additions & 2 deletions tests/e2e/tracehandler_testdata/happyPath.json
Original file line number Diff line number Diff line change
@@ -471,7 +471,7 @@
"Rewards": null,
"ConsumerChains": null,
"AssignedKeys": {
"bob": "consumervalcons1uuec3cjxajv5te08p220usrjhkfhg9wyref26m",
"bob": "providervalcons1uuec3cjxajv5te08p220usrjhkfhg9wydlduwz",
"carol": "providervalcons1kswr5sq599365kcjmhgufevfps9njf43c2pag0"
},
"ProviderKeys": {
@@ -526,7 +526,7 @@
"Rewards": null,
"ConsumerChains": null,
"AssignedKeys": {
"bob": "consumervalcons1uuec3cjxajv5te08p220usrjhkfhg9wyref26m",
"bob": "providervalcons1uuec3cjxajv5te08p220usrjhkfhg9wydlduwz",
"carol": "providervalcons1kswr5sq599365kcjmhgufevfps9njf43c2pag0"
},
"ProviderKeys": {