docs: add ADR for epochs #1550
Merged
docs: add ADR for epochs #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Docs
p-offtermatt
reviewed
Jan 8, 2024
|
|
||
| - Add a param that sets the number of blocks in an epoch, i.e., `BlocksPerEpoch`. | ||
| We can use `BlockHeight() % BlocksPerEpoch == 0` to decide when an epoch is over. | ||
| Note that `BlocksPerEpoch` can also be a hardcoded constant as it's unlikely that it will change often. |
There was a problem hiding this comment.
I think hardcoded constant isn't really a great option, since we don't want to force people to fork if they just need a different epoch, right?
There was a problem hiding this comment.
Sure. A parameter would be cleaner, but it's not a must. Especially as this will be code run on the Hub.
Co-authored-by: Philip Offtermatt <[email protected]>
Co-authored-by: Philip Offtermatt <[email protected]>
p-offtermatt
approved these changes
Jan 8, 2024
bermuell
reviewed
Jan 9, 2024
|
|
||
| The implementation of epochs requires the following changes: | ||
|
|
||
| - Add a param that sets the number of blocks in an epoch, i.e., `BlocksPerEpoch`. |
There was a problem hiding this comment.
is there a max value for BlocksPerEpoch which should not be exeeded?
There was a problem hiding this comment.
Not really. Of course reasonable values are needed to not increase too much the delay of propagating validator updates, see #1550 (comment).
bermuell
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1514
Add ADR for ICS Epochs.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:prefix in the PR titlemake build-docs)