Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dockerfile FROM statement #1541

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

insumity
Copy link
Contributor

@insumity insumity commented Dec 22, 2023

Problem
Trying to run the e2e tests locally would give:

OCI runtime exec failed: exec failed: unable to start container process: exec /usr/local/bin/hermes: no such file or directory: unknown
exit status 1
make: *** [test-e2e-short] Error 1

Solution
Fixed by adding --platform=linux/amd64 in the relevant FROM statement.
Also, added the Dockerfile in the test GitHub actions because a change there might lead to the tests failing.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@github-actions github-actions bot added the C:Build Assigned automatically by the PR labeler label Dec 22, 2023
@insumity insumity marked this pull request as ready for review December 22, 2023 14:21
@insumity insumity requested a review from a team as a code owner December 22, 2023 14:21
@p-offtermatt p-offtermatt changed the title fix dockerfile FROM statement chore: fix dockerfile FROM statement Dec 22, 2023
@insumity insumity marked this pull request as draft December 22, 2023 14:23
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Dec 22, 2023
@insumity insumity force-pushed the insumity/fix-Dockerfile branch from 3723c7a to 0cd5907 Compare December 22, 2023 14:38
@github-actions github-actions bot added the C:CI Assigned automatically by the PR labeler label Dec 22, 2023
@insumity insumity marked this pull request as ready for review December 22, 2023 14:55
@p-offtermatt
Copy link
Contributor

Let's also add the same FROM in Dockerfile.gaia, right?

@insumity insumity force-pushed the insumity/fix-Dockerfile branch from 1261984 to 4173c5c Compare December 22, 2023 15:06
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a nit. I also added a modification in Dockerfile.gaia, please check it out and revert if you think it's not correct

@@ -192,6 +192,8 @@ jobs:
**/go.sum
**/Makefile
Makefile
Dockerfile
Dockerfile.gaia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do Dockerfile
and Dockerfile.*
e.g. if we get a Dockerfile.test at some point, it's covered.
(or even just Dockerfile*, instead)

Copy link
Contributor

@bermuell bermuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls address comments from @p-offtermatt

@p-offtermatt p-offtermatt enabled auto-merge January 9, 2024 15:32
@p-offtermatt p-offtermatt added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit be84275 Jan 9, 2024
12 checks passed
@p-offtermatt p-offtermatt deleted the insumity/fix-Dockerfile branch January 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants