-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix dockerfile FROM statement #1541
Conversation
3723c7a
to
0cd5907
Compare
Let's also add the same FROM in Dockerfile.gaia, right? |
1261984
to
4173c5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a nit. I also added a modification in Dockerfile.gaia, please check it out and revert if you think it's not correct
.github/workflows/test.yml
Outdated
@@ -192,6 +192,8 @@ jobs: | |||
**/go.sum | |||
**/Makefile | |||
Makefile | |||
Dockerfile | |||
Dockerfile.gaia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do Dockerfile
and Dockerfile.*
e.g. if we get a Dockerfile.test at some point, it's covered.
(or even just Dockerfile*, instead)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pls address comments from @p-offtermatt
Problem
Trying to run the e2e tests locally would give:
Solution
Fixed by adding
--platform=linux/amd64
in the relevantFROM
statement.Also, added the
Dockerfile
in the test GitHub actions because a change there might lead to the tests failing.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...