Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update migration handling for consumer consensus v1->v2 #1539

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Dec 21, 2023

Description

Closes: #1538

Following the work in #1535 that refactored the provider this work refactors the consumer.

This PR does not affect anyone using the library in production, it instead outlines how to manage consensus version migrations and cleans up the repo.

NOTE: depends on work from #1535.
Merging main or rebasing is required before merging this.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@MSalopek MSalopek self-assigned this Dec 21, 2023
@MSalopek MSalopek requested a review from a team as a code owner December 21, 2023 14:56
@MSalopek MSalopek added the type: tech-debt Slows down development in the long run label Dec 21, 2023
@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler and removed type: tech-debt Slows down development in the long run labels Dec 21, 2023
Copy link
Contributor

@bermuell bermuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSalopek MSalopek force-pushed the masa/1538-consumer-throttle-migration-refactor branch from f57e002 to 8ef96e6 Compare December 21, 2023 19:47
@MSalopek MSalopek enabled auto-merge December 21, 2023 19:48
@mpoke mpoke removed C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Dec 22, 2023
@github-actions github-actions bot added the C:x/consumer Assigned automatically by the PR labeler label Dec 22, 2023
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you didn't move to the migration/ folder as on the provider?

@MSalopek MSalopek added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 308d283 Dec 22, 2023
17 checks passed
@MSalopek MSalopek deleted the masa/1538-consumer-throttle-migration-refactor branch December 22, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/consumer Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update consumer throttle migrations; refactor migrations
3 participants