-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add backtransform functionality to genesis transform cli #1534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We need docs on this. Consider adding them in this or a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some comments.
I think this is already in the docs, right?
https://cosmos.github.io/interchain-security/consumer-development/consumer-genesis-transformation
Could you double-check that everything there is still consistent with what this PR adapts?
Thanks, changes look good to me! |
9532b48
to
6d429df
Compare
app/consumer/genesis.go
Outdated
return nil, fmt.Errorf("marshalling transformation result failed: %v", err) | ||
} | ||
|
||
// remove all prehash_key_before_comparison entries not supported by ics23 versions used by v2.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going the shortcut here bypassing json result manipulation as element is deeply nested in consumer genesis type.
6d429df
to
505a77f
Compare
505a77f
to
0b8668a
Compare
Description
Closes: #1512
Changes will allow to transform exported consumer genesis data from version v2.x, v3.x, v4.x to a specified target version
v2.x, v3.x, v4.x . With that newer version of provider chain exports can be transformed for older consumer chains e.g. 2.x
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...