-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added a ramification of opt out #1533
Conversation
@@ -29,8 +29,9 @@ Refer to the [upgrading guide](https://github.com/cosmos/interchain-security/blo | |||
<!-- Add any highlights of this release --> | |||
|
|||
## ❤️ Contributors | |||
|
|||
<!-- markdown-link-check-disable --> | |||
* Informal Systems ([@informalinc](https://twitter.com/informalinc)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change because PR was failing on markdown-link checking.
We could also use Nitter instead but it's quite likely for Nitter to be down once in a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it easy to add a reference to the code that shows that this is happening?
I think it's probably hard, but if possible it would be cool to have something here
that future readers can check to convince themselves this is the behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
I think it might be a bit confusing to point to CometBFT code snippets as part of this ADR. It could be done though if you think it would add value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that works for me, thanks for going through the trouble!
Description
Added a ramification of ADR 009, namely that soft opt-out would delay the decision of blocks on consumer chains.
Probably, the most relevant document to read about rounds on the underlying Tendermint consensus algorithm is The latest gossip on BFT consensus paper where, among others, it's written:
And then in the pseudocode presented in
Algorithm 1
, we can see that if a proposer is down, other validators wouldprevote
onnil
and eventuallyOnTimeoutPrecommit
would be called and increase theround
number.Thanks to @sergio-mena for mentioning this!
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:
prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:
prefix in the PR titlemake build-docs
)