Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codespell nightly workflow #1505

Merged
merged 2 commits into from
Dec 15, 2023
Merged

ci: add codespell nightly workflow #1505

merged 2 commits into from
Dec 15, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Dec 13, 2023

Description

Closes: NA

Add workflow that opens PRs to fix spelling errors


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@mpoke mpoke requested a review from a team as a code owner December 13, 2023 20:38
@github-actions github-actions bot added the C:CI Assigned automatically by the PR labeler label Dec 13, 2023
@insumity
Copy link
Contributor

The way I understand this, this might create a PR every day with just spell corrections (?)
Is there a way to run this on every PR before it gets merged instead? This way, we only have it to run once against the whole repo and then each PR would always get spell checked before it gets merged.

@mpoke
Copy link
Contributor Author

mpoke commented Dec 14, 2023

The way I understand this, this might create a PR every day with just spell corrections (?)

Indeed

Is there a way to run this on every PR before it gets merged instead? This way, we only have it to run once against the whole repo and then each PR would always get spell checked before it gets merged.

Not sure how to do that. This solution was taken from the SDK repo :)

@p-offtermatt
Copy link
Contributor

Let's do this for now and refactor if it becomes annoying?

Copy link
Contributor

@bermuell bermuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: pls add new lines at the end of the files

@mpoke mpoke enabled auto-merge December 15, 2023 13:46
@mpoke mpoke added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit c939cde Dec 15, 2023
11 checks passed
@mpoke mpoke deleted the marius/codespell branch December 15, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CI Assigned automatically by the PR labeler
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants